Python: fix for 'run all' paragraphs #1033
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In current implementation `.interpret()` is not thread-safe and so in parallel one (esp on empty or graph paragraphs) 'Run All' fails with NPE in logs
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
Member
Author
|
CI failed due to networking issues Merging in master and branch-0.6 if there is no further discussion |
asfgit
pushed a commit
that referenced
this pull request
Jun 20, 2016
### What is this PR for? Switch to FIFO scheduler as in current implementation `.interpret()` is not thread-safe and so in parallel one 'Run All' fails some paragraphs with NPE in logs ### What type of PR is it? Bug Fix | Improvement ### How should this be tested? 'Run All' passes without NPE in logs i.e on this [Zeppelin notebook for python](https://www.zeppelinhub.com/viewer/notebooks/aHR0cHM6Ly9yYXcuZ2l0aHVidXNlcmNvbnRlbnQuY29tL2J6ei9pbmN1YmF0b3ItemVwcGVsaW4vMTkyZjU3YjZjMGZkMjc4NzgwZDI3NDAzMGY1YmJlOTZlZThkNzdiYi9ub3RlYm9vay8yQlFBMzVDSlovbm90ZS5qc29u) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Alexander Bezzubov <bzz@apache.org> Closes #1033 from bzz/fix/python-run-all and squashes the following commits: 72e9d62 [Alexander Bezzubov] Python: switch to FIFO scheduler (cherry picked from commit 85ee2dd) Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Switch to FIFO scheduler as in current implementation
.interpret()is not thread-safe and so in parallel one 'Run All' fails some paragraphs with NPE in logsWhat type of PR is it?
Bug Fix | Improvement
How should this be tested?
'Run All' passes without NPE in logs i.e on this Zeppelin notebook for python
Questions: