[DOC][MINOR] Add shell interpreter docs to _navigation.html #1138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/interpreter/shell.md
Outdated
| Note: Currently each command runs as Zeppelin user. | ||
|
|
||
| ### Example | ||
| > **Note :** Currently each command runs as Zeppelin user. |
Member
There was a problem hiding this comment.
perhaps it could help to explain "Zeppelin user" as "the user Zeppelin server is running as" (or similar)?
Member
|
LGTM |
Contributor
|
@felixcheung agree. |
Contributor
Author
|
@felixcheung I updated |
Member
|
LGTM |
PhilippGrulich
pushed a commit
to SWC-SENSE/zeppelin
that referenced
this pull request
Aug 8, 2016
### What is this PR for? After apache#1087 merged, a new docs `shell.md` was added. But in the docs website, still Shell interpreter link points to `pleasecontribute.html`. So I changed this link, applied TOC and added more descriptions. ### What type of PR is it? Documentation ### Todos * [x] - Change `pleasecontribute.html` -> `shell.html` * [x] - Apply TOC(table of contents) * [x] - Add more description to `shell.md` ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: AhyoungRyu <fbdkdud93@hanmail.net> Closes apache#1138 from AhyoungRyu/improve/shell-docs and squashes the following commits: 69d567d [AhyoungRyu] Address @felixcheung feedback fca76a6 [AhyoungRyu] Apply TOC to rest-credential.md c8e988b [AhyoungRyu] Change docs group manual -> interpreter a0bf1d5 [AhyoungRyu] Add shell.html to _navigation.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
After #1087 merged, a new docs
shell.mdwas added. But in the docs website, still Shell interpreter link points topleasecontribute.html. So I changed this link, applied TOC and added more descriptions.What type of PR is it?
Documentation
Todos
pleasecontribute.html->shell.htmlshell.mdQuestions: