[HOTFIX] Fix NullPointerException at org.apache.zeppelin.notebook.Paragraph.getRepl(Paragraph.java:204)#1150
Closed
Leemoonsoo wants to merge 3 commits intoapache:masterfrom
Closed
[HOTFIX] Fix NullPointerException at org.apache.zeppelin.notebook.Paragraph.getRepl(Paragraph.java:204)#1150Leemoonsoo wants to merge 3 commits intoapache:masterfrom
Leemoonsoo wants to merge 3 commits intoapache:masterfrom
Conversation
Member
|
Looks good to me - with this guy I can bind the interpreter to the notebook without NPE. Do not we have some Selenium tests doing so? I'd like to merge ASAP as a hotfix. |
PhilippGrulich
pushed a commit
to SWC-SENSE/zeppelin
that referenced
this pull request
Aug 8, 2016
…agraph.getRepl(Paragraph.java:204) ### What is this PR for? When notebook is being loaded, following error is raised after apache#836 ``` Caused by: java.lang.NullPointerException at org.apache.zeppelin.notebook.Paragraph.getRepl(Paragraph.java:204) at org.apache.zeppelin.notebook.Paragraph.getCurrentRepl(Paragraph.java:208) at org.apache.zeppelin.helium.Helium.suggestApp(Helium.java:138) at org.apache.zeppelin.rest.HeliumRestApi.suggest(HeliumRestApi.java:83) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.apache.cxf.service.invoker.AbstractInvoker.performInvocation(AbstractInvoker.java:180) at org.apache.cxf.service.invoker.AbstractInvoker.invoke(AbstractInvoker.java:96) ... 50 more ``` ### What type of PR is it? Hotfix ### Todos * [x] - Fix ### What is the Jira issue? ZEPPELIN-732, ZEPPELIN-1075 ### How should this be tested? Run Zeppelin and load any notebook. And see if there're unexpected exception raised. ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <moon@apache.org> Closes apache#1150 from Leemoonsoo/fix_npe and squashes the following commits: 10746f5 [Lee moon soo] adjust indentation 0471042 [Lee moon soo] Add unittest 3e8697b [Lee moon soo] Set interpreter factory into paragraph right after loaded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
When notebook is being loaded, following error is raised after #836
What type of PR is it?
Hotfix
Todos
What is the Jira issue?
ZEPPELIN-732, ZEPPELIN-1075
How should this be tested?
Run Zeppelin and load any notebook. And see if there're unexpected exception raised.
Questions: