Skip to content

Conversation

@cloverhearts
Copy link
Member

What is this PR for?

#1218
Establish a foundation to personalize the code editor settings.
Remove and set of ace.editor included in paragraph.controller.js.

What type of PR is it?

Improve

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-1259

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@cloverhearts
Copy link
Member Author

@corneadoug
please, can you review for this pr?
i divided to #1218 pr.

cloverhearts and others added 2 commits August 11, 2016 17:31
# Conflicts:
#	zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
@cloverhearts
Copy link
Member Author

ping

@corneadoug
Copy link
Contributor

@cloverhearts Sorry for the delay, I will take a look soon.

@cloverhearts
Copy link
Member Author

@corneadoug You're welcome, Thank you!

# Conflicts:
#	zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
# Conflicts:
#	zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
@cloverhearts
Copy link
Member Author

This feature is not mergeable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants