ZEPPELIN-1267. PySparkInterpreter doesn't work in spark 2.0 #1260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
\cc @jongyoul for review |
Member
|
Looks good to me. |
Member
|
I've tested it. LGTM. |
Member
|
Let's merge if there is no further discussion! |
Member
|
@zjffdu I tried current master branch with master set to local[*], Spark standalone and yarn-client both with/without |
Contributor
Author
|
I also use the latest master and build zeppelin with this command: |
Member
|
@zjffdu thank you for quick response, I was able to reproduce it and tested this patch fixes the issue! |
asfgit
pushed a commit
that referenced
this pull request
Aug 4, 2016
### What is this PR for? PySparkInterpreter doesn't work in spark 2.0 because pyspark and py4j is not distributed to executors. This PR extract the setup staff for pyspark interpreter into method setupConfForPySpark and use it for both spark1 and spark2. But this is just a short term solution, as I think this should be handled by spark rather than zeppelin, here zeppelin duplicate part of spark's work. In the long term, I'd like to resolve it in `ZEPPELIN-1263`. ### What type of PR is it? [Bug Fix] ### Todos * https://issues.apache.org/jira/browse/ZEPPELIN-1263 ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-1267 ### How should this be tested? Verify it manually. ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <zjffdu@apache.org> Closes #1260 from zjffdu/ZEPPELIN-1267 and squashes the following commits: 81d1d56 [Jeff Zhang] ZEPPELIN-1267. PySparkInterpreter doesn't work in spark 2.0 (cherry picked from commit 161dd0e) Signed-off-by: Mina Lee <minalee@apache.org>
PhilippGrulich
pushed a commit
to SWC-SENSE/zeppelin
that referenced
this pull request
Aug 8, 2016
### What is this PR for? PySparkInterpreter doesn't work in spark 2.0 because pyspark and py4j is not distributed to executors. This PR extract the setup staff for pyspark interpreter into method setupConfForPySpark and use it for both spark1 and spark2. But this is just a short term solution, as I think this should be handled by spark rather than zeppelin, here zeppelin duplicate part of spark's work. In the long term, I'd like to resolve it in `ZEPPELIN-1263`. ### What type of PR is it? [Bug Fix] ### Todos * https://issues.apache.org/jira/browse/ZEPPELIN-1263 ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-1267 ### How should this be tested? Verify it manually. ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <zjffdu@apache.org> Closes apache#1260 from zjffdu/ZEPPELIN-1267 and squashes the following commits: 81d1d56 [Jeff Zhang] ZEPPELIN-1267. PySparkInterpreter doesn't work in spark 2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
PySparkInterpreter doesn't work in spark 2.0 because pyspark and py4j is not distributed to executors. This PR extract the setup staff for pyspark interpreter into method setupConfForPySpark and use it for both spark1 and spark2. But this is just a short term solution, as I think this should be handled by spark rather than zeppelin, here zeppelin duplicate part of spark's work. In the long term, I'd like to resolve it in
ZEPPELIN-1263.What type of PR is it?
[Bug Fix]
Todos
What is the Jira issue?
How should this be tested?
Verify it manually.
Screenshots (if appropriate)
Questions: