[Optimization] Code editor key binding event optimization. #1287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $scope.editor.commands.bindKey('ctrl-.', 'startAutocomplete'); | ||
| $scope.editor.commands.bindKey('ctrl-space', null); | ||
|
|
||
| $scope.keyBindingEditorFocusAction = function(moveTarget, scrollValue) { |
Contributor
There was a problem hiding this comment.
This should be var, not $scope
…t row check logic
Member
Author
|
Sorry, i found a bug. |
Member
Author
|
Bug fixes completed. |
Member
|
Thanks for the patch. Could you create two paragraphs and write multiple lines of text (more than 3 lines) in the code editor and try move focus by up/down key? Cursor skips top/bottom line of text in the code editor. |
Member
Author
|
@Leemoonsoo |
Member
Author
|
@Leemoonsoo |
Member
|
Tested and LGTM. |
asfgit
pushed a commit
that referenced
this pull request
Aug 6, 2016
zeppelin custom key binding event optimization for Ace Code editor Improvement - [x] optimization for key binding and check logic For many in the code editor and typing quickly. The effect is greater when there are many Paragraph. * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: CloverHearts <cloverheartsdev@gmail.com> Closes #1287 from cloverhearts/dev/codeditorKeyBindOptimization and squashes the following commits: 76cd284 [CloverHearts] paragraph move jum bug fixed. 27f7146 [CloverHearts] Modify the style syntax for code editor e4c37b1 [CloverHearts] move to original key bind function for codeeditor optimiza 6a9edbe [CloverHearts] change access type $scope access member to local variable and add last row check logic 8cc63b7 [CloverHearts] fixed syntax error for editor key binding optimization. b37788d [CloverHearts] Code editor key binding event optimization. (cherry picked from commit ea76ca9) Signed-off-by: Lee moon soo <moon@apache.org>
PhilippGrulich
pushed a commit
to SWC-SENSE/zeppelin
that referenced
this pull request
Aug 8, 2016
### What is this PR for? zeppelin custom key binding event optimization for Ace Code editor ### What type of PR is it? Improvement ### Todos - [x] optimization for key binding and check logic ### How should this be tested? For many in the code editor and typing quickly. The effect is greater when there are many Paragraph. ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: CloverHearts <cloverheartsdev@gmail.com> Closes apache#1287 from cloverhearts/dev/codeditorKeyBindOptimization and squashes the following commits: 76cd284 [CloverHearts] paragraph move jum bug fixed. 27f7146 [CloverHearts] Modify the style syntax for code editor e4c37b1 [CloverHearts] move to original key bind function for codeeditor optimiza 6a9edbe [CloverHearts] change access type $scope access member to local variable and add last row check logic 8cc63b7 [CloverHearts] fixed syntax error for editor key binding optimization. b37788d [CloverHearts] Code editor key binding event optimization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
zeppelin custom key binding event optimization for Ace Code editor
What type of PR is it?
Improvement
Todos
How should this be tested?
For many in the code editor and typing quickly.
The effect is greater when there are many Paragraph.
Questions: