-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[MINOR] Doc fix for spark interpreter #1398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| <tr> | ||
| <th>spark-defaults.conf</th> | ||
| <th>SPARK_SUBMIT_OPTIONS</th> | ||
| <th>Applicable Interpreter</th> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK, there settings are applicable for all the spark interpreters. So I remove this column.
|
@zjffdu Thank you for updating Spark interpreter docs. Looks great I think 👍 |
|
@zjffdu Did you close this PR on purpose? |
|
Sorry @AhyoungRyu I didn't notice you PR is based on my branch and thought you will merge to master directly. |
Improve spark.md
|
@zjffdu It's okay :) LGTM 👍 |
|
Merging into master if there are no more discussions |
### What is this PR for? Several changes on doc of spark interpreter. * %spark, %sql, %pyspark only works when spark is the default interpreter group of note. So I update the doc to use the full interpreter name. * Add SparkSession for 2.0 * Also add comments inline with other changes to explain the reason. ### What type of PR is it? [Documentation] ### Todos * [ ] - Task ### What is the Jira issue? * No jira created. ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: AhyoungRyu <fbdkdud93@hanmail.net> Author: Jeff Zhang <zjffdu@apache.org> Author: Jeff Zhang <zjffdu@gmail.com> Closes apache#1398 from zjffdu/spark_doc_fix and squashes the following commits: ac01f2b [Jeff Zhang] Merge pull request #1 from AhyoungRyu/spark_doc_fix/ahyoung 5fa523f [AhyoungRyu] Fix typos 3c0f678 [AhyoungRyu] Add 'R' and refine a sentence 2336900 [AhyoungRyu] Improve spark.md 40d4b11 [Jeff Zhang] [MINOR] Doc fix for spark interpreter
What is this PR for?
Several changes on doc of spark interpreter.
What type of PR is it?
[Documentation]
Todos
What is the Jira issue?
Questions: