Skip to content

Conversation

@zjffdu
Copy link
Contributor

@zjffdu zjffdu commented Sep 2, 2016

What is this PR for?

Several changes on doc of spark interpreter.

  • %spark, %sql, %pyspark only works when spark is the default interpreter group of note. So I update the doc to use the full interpreter name.
  • Add SparkSession for 2.0
  • Also add comments inline with other changes to explain the reason.

What type of PR is it?

[Documentation]

Todos

  • - Task

What is the Jira issue?

  • No jira created.

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

<tr>
<th>spark-defaults.conf</th>
<th>SPARK_SUBMIT_OPTIONS</th>
<th>Applicable Interpreter</th>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, there settings are applicable for all the spark interpreters. So I remove this column.

@zjffdu
Copy link
Contributor Author

zjffdu commented Sep 2, 2016

\cc @Leemoonsoo @AhyoungRyu

@AhyoungRyu
Copy link
Contributor

@zjffdu Thank you for updating Spark interpreter docs. Looks great I think 👍
While I look through current Spark documentation page to review this PR, I found some typos, grammar errors and removed useless markdown escaping. So I fixed them based on your branch. If you don't mind, could you check zjffdu#1 out?

@zjffdu zjffdu closed this Sep 13, 2016
@AhyoungRyu
Copy link
Contributor

@zjffdu Did you close this PR on purpose?

@zjffdu
Copy link
Contributor Author

zjffdu commented Sep 13, 2016

Sorry @AhyoungRyu I didn't notice you PR is based on my branch and thought you will merge to master directly.

@zjffdu zjffdu reopened this Sep 13, 2016
@AhyoungRyu
Copy link
Contributor

@zjffdu It's okay :) LGTM 👍

@AhyoungRyu
Copy link
Contributor

Merging into master if there are no more discussions

@asfgit asfgit closed this in ba12ea3 Sep 20, 2016
pedrozatta pushed a commit to pedrozatta/zeppelin that referenced this pull request Oct 27, 2016
### What is this PR for?
Several changes on doc of spark interpreter.

* %spark, %sql, %pyspark only works when spark is the default interpreter group of note. So I update the doc to use the full interpreter name.
* Add SparkSession for 2.0
* Also add comments inline with other changes to explain the reason.

### What type of PR is it?
[Documentation]

### Todos
* [ ] - Task

### What is the Jira issue?
* No jira created.

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: AhyoungRyu <fbdkdud93@hanmail.net>
Author: Jeff Zhang <zjffdu@apache.org>
Author: Jeff Zhang <zjffdu@gmail.com>

Closes apache#1398 from zjffdu/spark_doc_fix and squashes the following commits:

ac01f2b [Jeff Zhang] Merge pull request #1 from AhyoungRyu/spark_doc_fix/ahyoung
5fa523f [AhyoungRyu] Fix typos
3c0f678 [AhyoungRyu] Add 'R' and refine a sentence
2336900 [AhyoungRyu] Improve spark.md
40d4b11 [Jeff Zhang] [MINOR] Doc fix for spark interpreter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants