[Zeppelin-1496] Apply Zeppelin-Web Good Practice Guide #1 to the code #1469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneadoug
force-pushed
the
ZEPPELIN-1496
branch
from
3964e26 to
9e8fec0
Compare
Contributor
Author
|
Ready for review. |
Contributor
Author
|
CI is green :) |
Contributor
Author
|
Merging if there is no discussions |
1 task
corneadoug
force-pushed
the
ZEPPELIN-1496
branch
from
9e8fec0 to
d3758bc
Compare
corneadoug
force-pushed
the
ZEPPELIN-1496
branch
from
d3758bc to
966cb27
Compare
pedrozatta
pushed a commit
to pedrozatta/zeppelin
that referenced
this pull request
Oct 27, 2016
### What is this PR for? This is some refactoring of zeppelin-web to apply the IIFE as stated in the Good Practice Guide #1 (https://zeppelin.apache.org/contribution/zeppelinweb/goodPracticeGuide01.html) ### What type of PR is it? Refactoring ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1496 ### How should this be tested? Run The webapp, and go around the page, things should work like usual. But overall, just need to check that there is no type or parameter mismatch during the refactoring process (controller to controller, params in $inject etc...) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Damien CORNEAU <corneadoug@gmail.com> Closes apache#1469 from corneadoug/ZEPPELIN-1496 and squashes the following commits: 966cb27 [Damien CORNEAU] refactor components controllers 1807cf6 [Damien CORNEAU] Refactor components directives 0055191 [Damien CORNEAU] Refactor components service and factory f86adb4 [Damien CORNEAU] Finish refactoring of App 409c65c [Damien CORNEAU] IIFE refactoring of job page 4c45e08 [Damien CORNEAU] Refactor for IIFE credential, home and interpreter controller 7e88eef [Damien CORNEAU] Add congiguration.controller.js 6adb522 [Damien CORNEAU] Move use strict outside IFFE ffba0f3 [Damien CORNEAU] Add IIFE to app.controller.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This is some refactoring of zeppelin-web to apply the IIFE as stated in the Good Practice Guide #1 (https://zeppelin.apache.org/contribution/zeppelinweb/goodPracticeGuide01.html)
What type of PR is it?
Refactoring
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1496
How should this be tested?
Run The webapp, and go around the page, things should work like usual.
But overall, just need to check that there is no type or parameter mismatch during the refactoring process (controller to controller, params in $inject etc...)
Questions: