[ZEPPELIN-2007] Fix flaky test: ShellInterpreterTest#testShellTimeout#1939
Closed
Leemoonsoo wants to merge 1 commit intoapache:masterfrom
Closed
[ZEPPELIN-2007] Fix flaky test: ShellInterpreterTest#testShellTimeout#1939Leemoonsoo wants to merge 1 commit intoapache:masterfrom
Leemoonsoo wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
I'm merging this to master as a hotfix. |
asfgit
pushed a commit
that referenced
this pull request
Jan 25, 2017
### What is this PR for? Fix flaky test ShellInterpreterTest#testShellTimeout https://issues.apache.org/jira/browse/ZEPPELIN-2007 this PR makes sure `testShellTimeout()` produce timeout error by increase gap between timeout and test value (from `61-60 = 1` to `4-2 = 2`). ### What type of PR is it? Hot Fix ### Todos * [x] - Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-2007 ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <moon@apache.org> Closes #1939 from Leemoonsoo/ZEPPELIN-2007 and squashes the following commits: 57c6a9b [Lee moon soo] Make ShellInterpreterTest faster, more reliable (cherry picked from commit 2ef8359) Signed-off-by: Mina Lee <minalee@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Fix flaky test ShellInterpreterTest#testShellTimeout https://issues.apache.org/jira/browse/ZEPPELIN-2007
this PR makes sure
testShellTimeout()produce timeout error by increase gap between timeout and test value (from61-60 = 1to4-2 = 2).What type of PR is it?
Hot Fix
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2007
Questions: