Skip to content

Conversation

@dlukyanov
Copy link
Contributor

What is this PR for?

Groovy Interpreter

What type of PR is it?

Feature

Todos

  • [ Tests ] - Task
  • [ Documentation ] - Task

What is the Jira issue?

[ZEPPELIN-2176]

How should this be tested?

Follow the groovy interpreter documentation samples

Questions:

  • Does the licenses files need update? YES
  • Is there breaking changes for older versions? NO
  • Does this needs documentation? YES

@AhyoungRyu
Copy link
Contributor

@dlukyanov Is this WIP or ready for review? If it's WIP, then could you update the title to sth like "[WIP][ZEPPELIN-2196] Groovy interpreter"? It'll be helpful to other reviewers to recognize this PR's status. You can remove WIP whenever you think it's done :)

@AhyoungRyu
Copy link
Contributor

And I think the other interpreter's PR can be helpful to you (e.g. A PR for BigQuery Interpreter: #1170 ). Especially this comment :)

@dlukyanov dlukyanov changed the title Groovy Interpreter [WIP] Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176] Feb 26, 2017
@dlukyanov
Copy link
Contributor Author

dlukyanov commented Feb 26, 2017

Hello, can somebody help me to understand jenkins failure

  • python ./travis_check.py dlukyanov 46d3ea6
    [2017-02-26 10:29:08] Author: dlukyanov, commit: 46d3ea6
    [2017-02-26 10:29:08] --------------------------------
    [2017-02-26 10:29:13] Get build status ...
    [2017-02-26 10:29:13] Can't find build for commit= 46d3ea6
    Build step 'Execute shell' marked build as failure
    Putting comment on the pull request
    Finished: FAILURE

@dlukyanov dlukyanov changed the title [WIP] Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176] Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176] Feb 27, 2017
@felixcheung
Copy link
Member

@dlukyanov
Copy link
Contributor Author

@felixcheung ,
it seems that jenkins job looking for travis build under the author, but i made branch under organization... are there any restrictions about author/organization?
and another point - seems there are troubles at travis-ci,i can't see any logs (error while trying to fetch the log), jobs like hanged... https://travis-ci.org/char-com-ua/zeppelin/builds/206271422
any suggestions?

@felixcheung
Copy link
Member

hmm, I don't know about organization @Leemoonsoo
as for log, travis was having problems yesterday, perhaps you can try again?

@Leemoonsoo
Copy link
Member

I've made a patch #2094 to make jenkins check repository under organization. Once #2094 is merged, then Jenkins will able to check this PR build status correctly.

@dlukyanov
Copy link
Contributor Author

@Leemoonsoo I see that #2094 is closed but I still have a problem with build
Should I move from org to user?

++ awk '{print $3}'
++ git log -n 1
++ grep '^Merge:'
+ COMMIT=826d1ef
+ '[' -z 826d1ef ']'
+ sleep 30
+ python ./travis_check.py dlukyanov 826d1ef
[2017-03-12 08:59:14] Author: dlukyanov, commit: 826d1ef
[2017-03-12 08:59:14] --------------------------------
[2017-03-12 08:59:19] Get build status ...
[2017-03-12 08:59:19] Can't find build for commit 826d1ef from dlukyanov
Build step 'Execute shell' marked build as failure

@Leemoonsoo
Copy link
Member

Could you try rebase or merge master to this PR, so this PR branch includes update on travis_check.py that #2094 made?

@dlukyanov
Copy link
Contributor Author

dlukyanov commented Mar 14, 2017

Closing this pull request because fork under organization can't be checked by jenkins job for now (or smth wrong with my hands))

Created new fork And new pull request [#2135]

@dlukyanov dlukyanov closed this Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants