add notification

[vgmartinez]

add notification when saved paragraph

[djoelz]

Where is Notification defined?

[vgmartinez]

is defined in bower_components/angular-ui-notification/dist/angular-ui-notification.min.js

[djoelz]

thanks! I can't find it under zeppelin-web\bower_components\angular-ui-notification folder. am I missing something?

[Madhuka]

@djoelz : Run the build then it will find it.
OR run bower install in zeppelin-web

[Leemoonsoo]

Thanks @vgmartinez for adding notification.

I think notification is going to be useful, in general. This branch notify 'Saved' message when code is autosaved by timer. I'm not sure about this particular notification, because

• Saving code already have visual indicator. (color of left vertical bar)
• Other actions (Run, etc) also saves code. Notifying only when autosaved by timer may confuse user, that other actions does not save the code.

By the way, here's a screenshot, how it looks

[Madhuka]

This is good. We can used notification for showing data validation messages.

[vgmartinez]

hi @Leemoonsoo ,
makes sense, sorry they had not seen the display ... but I think we can use notifications in other actions such as deleting a paragraph ... as they see?

[Leemoonsoo]

Yes, notification would be useful for many cases. (connection error, etc)