Skip to content

[ZEPPELIN-1470] limiting results from jdbc #2428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
herval wants to merge 2 commits into from
Closed

[ZEPPELIN-1470] limiting results from jdbc #2428

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b538c44
limiting results from jdbc
Jun 22, 2017
4f66469
display truncation message
Jun 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,6 +681,11 @@ private InterpreterResult executeSql(String propertyKey, String sql,
for (int i = 0; i < sqlArray.size(); i++) {
String sqlToExecute = sqlArray.get(i);
statement = connection.createStatement();

// fetch n+1 rows in order to indicate there's more rows available (for large selects)
statement.setFetchSize(getMaxResult());
statement.setMaxRows(getMaxResult() + 1);
Copy link
Member

@felixcheung felixcheung Jul 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so hopefully getMaxResult() won't return Integer.MAX_VALUE? because +1 will overflow?

Copy link
Author

@herval herval Jul 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless someone specifies a fetch size of two billion rows, this should be fine (the UI would break and Zeppelin would run OOM and the world would melt w/ that amount of rows anyway, so I wouldn't particularly worry about that scenario? :-))

Copy link
Member

@felixcheung felixcheung Jul 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha, yes


if (statement == null) {
return new InterpreterResult(Code.ERROR, "Prefix not found.");
}
Expand Down