Skip to content

Conversation

@zjffdu
Copy link
Contributor

@zjffdu zjffdu commented Jun 19, 2018

What is this PR for?

This is Just to update scala to 2.11.12 which to be consistent with spark (SPARK-24418)

What type of PR is it?

[Improvement]

Todos

  • - Task

What is the Jira issue?

How should this be tested?

  • CI pass

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@zjffdu zjffdu changed the title ZEPPELIN-3551. Upgrade Scala to 2.11.12 [WIP] ZEPPELIN-3551. Upgrade Scala to 2.11.12 Jun 20, 2018
@zjffdu zjffdu force-pushed the ZEPPELIN-3551 branch 5 times, most recently from dcf0c5d to 8472608 Compare June 21, 2018 02:55
@zjffdu zjffdu changed the title [WIP] ZEPPELIN-3551. Upgrade Scala to 2.11.12 ZEPPELIN-3551. Upgrade Scala to 2.11.12 Jun 21, 2018
@zjffdu
Copy link
Contributor Author

zjffdu commented Jun 21, 2018

@Leemoonsoo @felixcheung Could you help review it ? Thanks

@zjffdu zjffdu force-pushed the ZEPPELIN-3551 branch 2 times, most recently from 3cf185e to 0594558 Compare June 25, 2018 04:38
@zjffdu
Copy link
Contributor Author

zjffdu commented Jun 26, 2018

Will merge it if no more comments

@Leemoonsoo
Copy link
Member

LGTM

Copy link
Member

@felixcheung felixcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works? spark had problems upgrading to newer than 2.11.8

@felixcheung
Copy link
Member

felixcheung commented Jun 26, 2018

specifically in SPARK-24418 - there code changes needed but not release yet (Spark 2.4.0?)

@zjffdu
Copy link
Contributor Author

zjffdu commented Jun 26, 2018

I tested it against spark master branch, and it works. What kind of problems does spark have on 2.11.12 ? I notice SPARK-24418 is already merged.

@felixcheung
Copy link
Member

something in SparkILoop. given that I don't think we can/should upgrade scala broadly - it might only work for Spark 2.4.0 (unreleased) but not older/current releases

@zjffdu
Copy link
Contributor Author

zjffdu commented Jun 26, 2018

Thanks @felixcheung , I will revert the change in the root pom file and only update scala version in spark module.

@felixcheung
Copy link
Member

felixcheung commented Jun 27, 2018

? it looks like spark.version is 2.2.0. Or under profile, 2.3.0
as far as I know SPARK-24418 is fixed only in (unreleased) master branch

@zjffdu
Copy link
Contributor Author

zjffdu commented Jun 27, 2018

It is to fine to compile with spark 2.2, the main change is on SparkScala211Interpreter.scala which is due to scala repl api changes in scala 2.11.12.

@felixcheung
Copy link
Member

felixcheung commented Jun 27, 2018 via email

@zjffdu
Copy link
Contributor Author

zjffdu commented Jun 28, 2018

This is for the next release of zeppelin which I suppose should supported the latest spark 2.4.0 which would use scala 2.11.12. Just want to catch up with spark.

@felixcheung
Copy link
Member

well, ok. though might be hard to tell - we are juggling multiple releases 2.1.3, 2.2.2, 2.3.2 - might take some time to get to 2.4.0.

@zjffdu
Copy link
Contributor Author

zjffdu commented Jun 28, 2018

Anyway, this PR is just for the next release of spark that supports scala 2.11.12, I can hold it if you have any concern

@dongjoon-hyun
Copy link
Member

Hi, @zjffdu , @felixcheung , @Leemoonsoo .

Since Spark 2.1.3/2.2.2/2.3.2 is out and Spark 2.4.0 RC3 is started, can we restart this?

@HyukjinKwon
Copy link
Member

Hey @zjffdu, busy? I can take this over - looks there's only minor conflict.

@zjffdu
Copy link
Contributor Author

zjffdu commented Dec 4, 2018

Thanks @HyukjinKwon feel free to take over this

@github-actions
Copy link

This pull request has been inactive for over a year. If no further activity occurs within the next 30 days, it will be automatically closed. If you believe this PR is still relevant, please feel free to leave a comment or make an update. Thank you!

@github-actions github-actions bot added the Stale label Jul 19, 2025
@github-actions
Copy link

This pull request has been automatically closed due to prolonged inactivity (over one year without updates). If you feel this was done in error or would like to continue the discussion, feel free to reopen it. Thank you for your contributions!

@github-actions github-actions bot closed this Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants