ZEPPELIN-367 Sync with secondary storage when listing notebooks #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
triggering CI build |
Member
|
Tested and LGTM |
Member
|
Looks good. But could you rebase and trigger CI again? |
added 2 commits
November 3, 2015 11:06
khalidhuseynov
force-pushed
the
sync-on-list
branch
from
5e32503 to
e2cf5d9
Compare
Member
Author
|
@Leemoonsoo done with that |
Member
|
LGTM. merge if there're no more discussions |
lelou6666
pushed a commit
to lelou6666/incubator-zeppelin
that referenced
this pull request
Mar 25, 2016
Scatter chart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves https://issues.apache.org/jira/browse/ZEPPELIN-367 by synchronizing with secondary storage when reloading all notebooks into memory. Currently, existing
ZEPPELIN_NOTEBOOK_RELOAD_FROM_STORAGEfrom #331 is used as a flag since these functionalities are correlated, however it can be separated into distinct flag as well.