Skip to content

[ZEPPELIN-49] Interpreter.getProperty returns wrong value#41

Closed
jongyoul wants to merge 1 commit intoapache:masterfrom
jongyoul:ZEPPELIN-49
Closed

[ZEPPELIN-49] Interpreter.getProperty returns wrong value#41
jongyoul wants to merge 1 commit intoapache:masterfrom
jongyoul:ZEPPELIN-49

Conversation

@jongyoul
Copy link
Member

  • Fixed to return p, not property

@RamVenkatesh
Copy link
Contributor

LGTM!

@jongyoul
Copy link
Member Author

@RamVenkatesh Thanks.

@bzz
Copy link
Member

bzz commented Apr 17, 2015

Looks great!
Any way to test it to avoid further errors, by the way?

@jongyoul
Copy link
Member Author

@bzz Do you want to test the method of Interpreter.getProperty itself? It can help make sample subclass of Interpreter including static register codes and then make an instance with some properties and and them manually. Do you think it is good?

@bzz
Copy link
Member

bzz commented Apr 17, 2015

@jongyoul That would be great, but this sounds too complicated for such a change.. Do you think it worth doing now?

@jongyoul
Copy link
Member Author

If we have a plan to change an implementation of Interpreter, it would be good. Otherwise, it's a little tricky. Please tell me your plan.

@bzz
Copy link
Member

bzz commented Apr 17, 2015

I agree, lets address it in separate PR later, in case we actually need it.

@bzz
Copy link
Member

bzz commented Apr 17, 2015

Merging this one if there is no discussion

@asfgit asfgit closed this in f86a4e9 Apr 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants