[ZEPPELIN-49] Interpreter.getProperty returns wrong value#41
Closed
jongyoul wants to merge 1 commit intoapache:masterfrom
Closed
[ZEPPELIN-49] Interpreter.getProperty returns wrong value#41jongyoul wants to merge 1 commit intoapache:masterfrom
jongyoul wants to merge 1 commit intoapache:masterfrom
Conversation
Member
jongyoul
commented
Apr 16, 2015
- Fixed to return p, not property
- Fixed to return p, not property
Contributor
|
LGTM! |
Member
Author
|
@RamVenkatesh Thanks. |
Member
|
Looks great! |
Member
Author
|
@bzz Do you want to test the method of Interpreter.getProperty itself? It can help make sample subclass of Interpreter including static register codes and then make an instance with some properties and and them manually. Do you think it is good? |
Member
|
@jongyoul That would be great, but this sounds too complicated for such a change.. Do you think it worth doing now? |
Member
Author
|
If we have a plan to change an implementation of Interpreter, it would be good. Otherwise, it's a little tricky. Please tell me your plan. |
Member
|
I agree, lets address it in separate PR later, in case we actually need it. |
Member
|
Merging this one if there is no discussion |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.