-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ZEPPELIN-5946][FOLLOWUP] Use Spark 3.4.1 in default #4652
Conversation
spark/scala-2.13/src/main/scala/org/apache/zeppelin/spark/SparkScala213Interpreter.scala
Outdated
Show resolved
Hide resolved
Thx for the follow-up. |
The failed Kotlin test seems to be https://youtrack.jetbrains.com/issue/KT-38325 I suppose we must upgrade Kotlin first to address it. Unfortunately, the Kotlin interpreter uses a very old version (1.3.x, the latest is 1.9.x), and couple with lots of unstable APIs. |
40052ee
to
1257855
Compare
2df3350
to
d644e77
Compare
@pan3793 |
@Reamer not yet, I need to revert some changes. Sorry, I'm quite busy these days, will find the time to finish it ASAP. |
Co-authored-by: Matthias Koch <23187557+matthias-koch@users.noreply.github.com>
0da6c9e
to
bb0b774
Compare
The profiles |
cc @Reamer |
The profiles I see accesses to these properties in the Zeppelin Display Module and Zeppelin Distribution Module. Unfortunately, I don't currently know why Scala dependencies are needed in the Zeppelin Distribution Module. zeppelin/zeppelin-display/pom.xml Lines 34 to 55 in 85bb3b4
zeppelin/zeppelin-distribution/pom.xml Lines 49 to 73 in 85bb3b4
|
Oh, I missed the Zeppelin Display Module(it does not appear when I do global search using IDEA), it leverages the scala-xml to build |
Emm, is "Zeppelin Display Module" only used by "Zeppelin: Spark Interpreter"? If so, I suppose the Zeppelin core becomes scala free if we can merge this module into "Zeppelin: Spark Interpreter" |
As far as I know, the Zeppelin display module is only used by the Spark interpreter. If it is possible we can merge the Display Module to the Spark Interpreter Module. |
Thanks for information, would like a try in another PR. I limit this PR's scope to the spark related stuffs, CI already passed, and the last commit only touch the docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I will merge this pull request on Friday as long as no other comment is received. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed this PR. LGTM
* [ZEPPELIN-5946][FOLLOWUP] Use Spark 3.4.1 and Scala 2.12 in default * Update docs/setup/basics/how_to_build.md Co-authored-by: Matthias Koch <23187557+matthias-koch@users.noreply.github.com> * reflect * default 2.11 --------- Co-authored-by: Matthias Koch <23187557+matthias-koch@users.noreply.github.com>
What is this PR for?
Followup ZEPPELIN-5946, Use Spark 3.4.1 in default
What type of PR is it?
Improvement
Documentation
Todos
What is the Jira issue?
ZEPPELIN-5946
How should this be tested?
Pass GA
Screenshots (if appropriate)
Questions: