-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ZEPPELIN-5976] Support Flink 1.18 #4739
base: master
Are you sure you want to change the base?
Conversation
Same error I faced in my previous try, but no idea after some digging ... |
Most likely it is due to scala version |
.classLoader(Thread.currentThread().getContextClassLoader()) | ||
.config((ReadableConfig) config) | ||
.catalogStoreHolder( | ||
CatalogStoreHolder.newBuilder() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, thank you for the PR. I was able to compile your branch and it booted up and worked as expected, but the catalog registration did not work in the sense of adding a file catalog store. Looking in the Flink repo, it looks like they started instantiating the catalog manager differently. I don't know if the current flink shim structure is easily adapted to the new utilities added or something else needs to be done. If I get time this weekend I'd like to build off your work to see if we can get it working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for taking a look at it. I stumbled upon the same - was a bit too quick to celebrate after getting it up and running initially.
Any updates on this? |
I pushed my previous try in #4864, anyone interested in could take over ... |
What is this PR for?
This PR aims to support Flink 1.18
What type of PR is it?
Feature
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-5976
How should this be tested?
Pass GA.
Screenshots (if appropriate)
Questions: