Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-6126] Remove hadoop dependencies out of the final zeppelin-web.war #4871

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

Reamer
Copy link
Contributor

@Reamer Reamer commented Oct 9, 2024

What is this PR for?

This PR removes the Hadoop dependencies in the zeppelin-web.war file. At the moment it is not clear to me how this behavior came about in Zeppelin.

Build Command: ./mvnw clean package -DskipTests -Pinclude-hadoop -Pweb-classic -Pweb-dist -pl zeppelin-web -am

What type of PR is it?

Bug Fix

What is the Jira issue?

Screenshots (if appropriate)

Before:

15:53 $ ls -lh zeppelin-web/target/
insgesamt 47M
drwxrwxr-x  3 pdallig pdallig 4,0K Okt  9 15:51 classes
drwxrwxr-x  2 pdallig pdallig 4,0K Okt  9 15:51 maven-archiver
drwxrwxr-x  3 pdallig pdallig 4,0K Okt  9 15:51 maven-shared-archive-resources
drwxrwxr-x  3 pdallig pdallig 4,0K Okt  9 15:51 test-classes
drwxrwxr-x 11 pdallig pdallig 4,0K Okt  9 15:51 zeppelin-web-0.12.0-SNAPSHOT
-rw-rw-r--  1 pdallig pdallig  47M Okt  9 15:51 zeppelin-web-0.12.0-SNAPSHOT.war

grafik

After:

15:53 $ ls -lh zeppelin-web/target/
insgesamt 3,1M
drwxrwxr-x  3 pdallig pdallig 4,0K Okt  9 15:57 classes
drwxrwxr-x  2 pdallig pdallig 4,0K Okt  9 15:57 maven-archiver
drwxrwxr-x  3 pdallig pdallig 4,0K Okt  9 15:56 maven-shared-archive-resources
drwxrwxr-x  3 pdallig pdallig 4,0K Okt  9 15:57 test-classes
drwxrwxr-x 11 pdallig pdallig 4,0K Okt  9 15:57 zeppelin-web-0.12.0-SNAPSHOT
-rw-rw-r--  1 pdallig pdallig 3,1M Okt  9 15:57 zeppelin-web-0.12.0-SNAPSHOT.war

grafik

Questions:

  • Does the license files need to update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@Reamer Reamer changed the title [ZEPPELIN-6126] Remove hadoop dependencies out of the final war [ZEPPELIN-6126] Remove hadoop dependencies out of the final zeppelin-web.war Oct 9, 2024
@Reamer Reamer merged commit bdf5b06 into apache:master Oct 10, 2024
27 of 28 checks passed
asfgit pushed a commit that referenced this pull request Oct 10, 2024
…web.war

### What is this PR for?
This PR removes the Hadoop dependencies in the zeppelin-web.war file. At the moment it is not clear to me how this behavior came about in Zeppelin.

Build Command: `./mvnw clean package -DskipTests -Pinclude-hadoop -Pweb-classic -Pweb-dist -pl zeppelin-web -am`

### What type of PR is it?
Bug Fix

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-6126

### Screenshots (if appropriate)
Before:
```
15:53 $ ls -lh zeppelin-web/target/
insgesamt 47M
drwxrwxr-x  3 pdallig pdallig 4,0K Okt  9 15:51 classes
drwxrwxr-x  2 pdallig pdallig 4,0K Okt  9 15:51 maven-archiver
drwxrwxr-x  3 pdallig pdallig 4,0K Okt  9 15:51 maven-shared-archive-resources
drwxrwxr-x  3 pdallig pdallig 4,0K Okt  9 15:51 test-classes
drwxrwxr-x 11 pdallig pdallig 4,0K Okt  9 15:51 zeppelin-web-0.12.0-SNAPSHOT
-rw-rw-r--  1 pdallig pdallig  47M Okt  9 15:51 zeppelin-web-0.12.0-SNAPSHOT.war
```
![grafik](https://github.com/user-attachments/assets/decd7a91-5da6-44b1-b695-d8f9d6309b94)

After:
```
15:53 $ ls -lh zeppelin-web/target/
insgesamt 3,1M
drwxrwxr-x  3 pdallig pdallig 4,0K Okt  9 15:57 classes
drwxrwxr-x  2 pdallig pdallig 4,0K Okt  9 15:57 maven-archiver
drwxrwxr-x  3 pdallig pdallig 4,0K Okt  9 15:56 maven-shared-archive-resources
drwxrwxr-x  3 pdallig pdallig 4,0K Okt  9 15:57 test-classes
drwxrwxr-x 11 pdallig pdallig 4,0K Okt  9 15:57 zeppelin-web-0.12.0-SNAPSHOT
-rw-rw-r--  1 pdallig pdallig 3,1M Okt  9 15:57 zeppelin-web-0.12.0-SNAPSHOT.war
```
![grafik](https://github.com/user-attachments/assets/63366c81-392a-4053-bcdf-ea13768c3860)

### Questions:
* Does the license files need to update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


Closes #4871 from Reamer/remove_hadoop_from_web.

Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com>
@Reamer Reamer deleted the remove_hadoop_from_web branch October 10, 2024 09:27
@Reamer
Copy link
Contributor Author

Reamer commented Oct 10, 2024

also pushed to branch-0.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants