Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-6132] Bump Maven 3.9.9 and Maven Wrapper 3.3.2 #4879

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Oct 18, 2024

What is this PR for?

Install the latest Maven 3.9.9 locally, and run mvn wrapper:wrapper -Dtype=source

https://maven.apache.org/wrapper/index.html#usage-with-or-without-binary-jar

Note: Apache project does not recommend shipping binary files in source release, so this PR replaces .mvn/wrapper/maven-wrapper.jar with .mvn/wrapper/MavenWrapperDownloader.java

What type of PR is it?

Improvement

What is the Jira issue?

ZEPPELIN-6132

How should this be tested?

Pass GHA.

Screenshots (if appropriate)

Questions:

  • Does the license files need to update? No.
  • Is there breaking changes for older versions? No.
  • Does this needs documentation? No.

@pan3793 pan3793 requested review from Reamer and jongyoul October 18, 2024 14:55
Copy link
Contributor

@Reamer Reamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the fact that you are removing the binary from the SCM. Java as the only requirement is great.

Many thanks for the change.

@Reamer Reamer merged commit 4fb401f into apache:master Oct 22, 2024
28 checks passed
asfgit pushed a commit that referenced this pull request Oct 22, 2024
### What is this PR for?

Install the latest Maven 3.9.9 locally, and run `mvn wrapper:wrapper -Dtype=source`

https://maven.apache.org/wrapper/index.html#usage-with-or-without-binary-jar

Note: Apache project does not recommend shipping binary files in source release, so this PR replaces `.mvn/wrapper/maven-wrapper.jar` with `.mvn/wrapper/MavenWrapperDownloader.java`

### What type of PR is it?

Improvement

### What is the Jira issue?

ZEPPELIN-6132

### How should this be tested?

Pass GHA.

### Screenshots (if appropriate)

### Questions:
* Does the license files need to update? No.
* Is there breaking changes for older versions? No.
* Does this needs documentation? No.

Closes #4879 from pan3793/ZEPPELIN-6132.

Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com>
(cherry picked from commit 4fb401f)
Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants