[ZEPPELIN-6151] Remove AngularJS -> Angular Code Migration Suggestion Feature #4900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
approved these changes
Nov 19, 2024
|
Thanks, merged to master/0.12 |
pan3793
pushed a commit
that referenced
this pull request
Nov 25, 2024
… Feature ### What is this PR for? I propose removing the feature in Zeppelin's new UI that converts AngularJS code to Angular code. This feature currently prompts users when they run code with the `%angular` prefix, asking whether to migrate AngularJS code to Angular, and performs the migration if confirmed. The reasons for suggesting its removal are as follows: - The library supporting this feature is not compatible with the latest Angular versions due to peer dependency issues, making it difficult to upgrade Angular. - It is likely that this feature is not widely used by the community. Removing this feature will reduce unnecessary library dependencies, which will help streamline future updates to the latest Angular versions. If you have any other opinions, please feel free to share them. ### What type of PR is it? Removing Feature ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-6151 ### How should this be tested? * Strongly recommended: add automated unit tests for any new or changed behavior * Outline any manual steps to test the PR here. ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes #4900 from tbonelee/remove-ng1-migration. Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit ae48f71) Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
I propose removing the feature in Zeppelin's new UI that converts AngularJS code to Angular code.
This feature currently prompts users when they run code with the
%angularprefix, asking whether to migrate AngularJS code to Angular, and performs the migration if confirmed.The reasons for suggesting its removal are as follows:
Removing this feature will reduce unnecessary library dependencies, which will help streamline future updates to the latest Angular versions.
If you have any other opinions, please feel free to share them.
What type of PR is it?
Removing Feature
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-6151
How should this be tested?
Screenshots (if appropriate)
Questions: