Skip to content

[ZEPPELIN-6202] Fix %20 showing in notebook tree by URL-decoding note file paths #4947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Reamer merged 3 commits into from
Jul 29, 2025
Merged

[ZEPPELIN-6202] Fix %20 showing in notebook tree by URL-decoding note file paths #4947

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d9abfda
[ZEPPELIN-6202] Decode %20 → space in VFS notebook paths
ParkGyeongTae Jun 15, 2025
5981784
[ZEPPELIN-6202] Replace getURI() with getPath() for noteFileName to s…
ParkGyeongTae Jul 21, 2025
c0c271f
[ZEPPELIN-6202] Fix path decoding issue by replacing getPath() with d…
ParkGyeongTae Jul 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/VFSNotebookRepo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
import java.io.OutputStream;
import java.net.URI;
import java.net.URISyntaxException;
import java.net.URLDecoder;
import java.nio.charset.StandardCharsets;
import java.util.ArrayList;
import java.util.Collections;
import java.util.HashMap;
Expand Down Expand Up @@ -114,9 +116,13 @@ private Map<String, NoteInfo> listFolder(FileObject fileObject) throws IOExcepti
noteInfos.putAll(listFolder(child));
}
} else {
// getPath() method returns a string without root directory in windows, so we use getURI() instead
// windows does not support paths with "file:///" prepended. so we replace it by "/"
String noteFileName = fileObject.getName().getURI().replace("file:///", "/");
// getPath() drops the drive on Windows, so use getURI().
// Decode URI to change %20 to spaces.
// Windows cannot handle "file:///", replace it with "/".
String noteFileName = URLDecoder.decode(
fileObject.getName().getURI(), StandardCharsets.UTF_8
).replace("file:///", "/");

if (noteFileName.endsWith(".zpln")) {
try {
String noteId = getNoteId(noteFileName);
Expand Down
Loading