[ZEPPELIN-6206] Fix notebook paths in job manager page #4951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Perhaps this is related to #4947 |
Contributor
Author
|
@Reamer That one addresses URI-encoded names, whereas this PR fixes a routing issue in Angular, where links were generated as relative paths instead of root-based, leading to incorrect URLs under nested routes like So while they seem related in topic, I think the underlying causes and fixes are different. |
Member
|
👍 LGTM |
Reamer
approved these changes
Jun 30, 2025
Contributor
Reamer
left a comment
Reamer
left a comment
There was a problem hiding this comment.
Thank you for the correction
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Jun 30, 2025
### What is this PR for? URLs to notebook page are set wrong in job manager page ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-6206 ### How should this be tested? - Enable cron and job manager configurations and check a links in the page - `zeppelin.jobmanager.enable` : `true` - `zeppelin.notebook.cron.enable`: `true` - `zeppelin.notebook.cron.folders` : `/`  ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes #4951 from tbonelee/fix-notebook-path. Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com> (cherry picked from commit 1ca383e) Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com>
Contributor
|
Merged into master and branch-0.12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
URLs to notebook page are set wrong in job manager page
What type of PR is it?
Bug Fix
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-6206
How should this be tested?
zeppelin.jobmanager.enable:truezeppelin.notebook.cron.enable:truezeppelin.notebook.cron.folders:/Questions: