ZEPPELIN-491: Giving fixed height to container when result type is text #519
Conversation
|
Also I've removed "loadResultType" function calls, as it did not had any respective loadResultType declaration or implementation. |
There was a problem hiding this comment.
I picked template function from $scope.renderHtml; fixed both $scope.renderHtml and $scope.renderText
prabhjyotsingh
force-pushed
the
ZEPPELIN-491
branch
10 times, most recently
from
93c8f38 to
3f14de7
Compare
prabhjyotsingh
force-pushed
the
ZEPPELIN-491
branch
from
3f14de7 to
dc96ed6
Compare
|
Also I think this should have scroll to bottom of output button.
|
|
Have implement follow scroll to the end and scroll to top. If there is a streaming output user can always have an eye on end of scroll.
|
|
Looks good. Can we get some attention from committers. Thanks! |
|
wow you are building Zeppelin from within Zeppelin ;) |
| ng-click="scrollParagraphDown()" ></div> | ||
| <div id="p{{paragraph.id}}_text" | ||
| style="max-height: {{paragraph.config.graph.height}}px; overflow: auto" | ||
| ng-scroll="someFunction()" |
There was a problem hiding this comment.
What is that line for? I didn't see any change when trying with and without.
Not sure if its necessary since someFunction doesn't exist anywhere
There was a problem hiding this comment.
Totally missed to remove this.
|
Could you use the same tooltip as everywhere else in zeppelin for those two buttons? |
|
@corneadoug Thanks for the review. I was just experimenting with look and feel of those two buttons, but what you recommend makes more sense. |
prabhjyotsingh
force-pushed
the
ZEPPELIN-491
branch
from
e7e2f90 to
fc95003
Compare
- have standard toooltip for Follow output and scroll top
prabhjyotsingh
force-pushed
the
ZEPPELIN-491
branch
from
fc95003 to
287fff8
Compare
|
@corneadoug does this looks ok? |
|
Yes, LGTM |
|
merging if no further discussion |
4 participants
In current behaviour we have a fixed height for result container that contains either graph or table, but if type is text then the container expands to infinitely.
When type is text; then this is mostly logs, so we can have scroll around it and have fixed height for this container.
Before
After
