Skip to content

Fix when result of paragraph contains carriage return#538

Closed
prabhjyotsingh wants to merge 1 commit intoapache:masterfrom
prabhjyotsingh:multilineOutputFix
Closed

Fix when result of paragraph contains carriage return#538
prabhjyotsingh wants to merge 1 commit intoapache:masterfrom
prabhjyotsingh:multilineOutputFix

Conversation

@prabhjyotsingh
Copy link
Contributor

What is this PR for?

When the result in paragraph contains "carriage return" or "line feed", they are getting displayed in single line. The output should be in multiline.

What type of PR is it?

Bug Fix

Screenshots

Before
screen shot 2015-12-16 at 11 26 08 am

After
screen shot 2015-12-16 at 11 27 22 am

@corneadoug
Copy link
Contributor

@prabhjyotsingh I removed it to fix #531
Can you think of something that satisfies both issues?

@prabhjyotsingh
Copy link
Contributor Author

Yes thanks @corneadoug, just realised, after making a PR. This should fix it.

white-space: pre-wrap;

also, there were multiple display: block and margin entries. Refactor those as well.

@prabhjyotsingh
Copy link
Contributor Author

Does this look ok to be merged ?
Have tested this on IE10+, FF42, Chrome46, Safari9.

@corneadoug
Copy link
Contributor

@prabhjyotsingh I will test that tomorrow. If it's good I will merge it the same day

@corneadoug
Copy link
Contributor

Tested, working great.
Merging if there is no more discussions

@asfgit asfgit closed this in 47eb95a Dec 21, 2015
@prabhjyotsingh prabhjyotsingh deleted the multilineOutputFix branch June 1, 2016 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants