Skip to content

ZEPPELIN-508 Interpreter binding cancel button doesn't work #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AhyoungRyu wants to merge 6 commits into from
Closed

ZEPPELIN-508 Interpreter binding cancel button doesn't work #548

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f39d4f5
ZEPPELIN-508 Interpreter binding cancel button doesn't work
AhyoungRyu Dec 17, 2015
62b1349
Fix typo : Notihing -> Nothing
AhyoungRyu Dec 17, 2015
e946e8d
Remove useless dialog
AhyoungRyu Dec 17, 2015
63eb0ae
Remove space between colon
AhyoungRyu Dec 17, 2015
2d1d915
Fix else statement position
AhyoungRyu Dec 19, 2015
3873545
Remove useless space between parenthesis
AhyoungRyu Dec 19, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions zeppelin-web/src/app/notebook/notebook.controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,15 +499,17 @@ angular.module('zeppelinWebApp').controller('NotebookCtrl', function($scope, $ro
if (isSettingDirty()) {
BootstrapDialog.confirm({
title: '',
message: 'Changes will be discarded',
message: 'Changes will be discarded.',
callback: function(result) {
if (result) {
$scope.$apply(function () {
$scope.$apply(function() {
$scope.showSetting = false;
});
}
}
});
} else {
$scope.showSetting = false;
}
Copy link
Member

@minahlee minahlee Dec 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just $scope.showSetting = false; wouldn't be enough?
Personally I wouldn't expect alert message in this case.
And after clicking cancel, having 'cancel' and 'ok' button choice feels a bit awkward for me.

Copy link
Contributor

@corneadoug corneadoug Dec 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Mina, no need for Dialog here

};

Expand Down