ZEPPELIN-508 Interpreter binding cancel button doesn't work#548
Closed
AhyoungRyu wants to merge 6 commits intoapache:masterfrom
Closed
ZEPPELIN-508 Interpreter binding cancel button doesn't work#548AhyoungRyu wants to merge 6 commits intoapache:masterfrom
AhyoungRyu wants to merge 6 commits intoapache:masterfrom
Conversation
Member
There was a problem hiding this comment.
Just $scope.showSetting = false; wouldn't be enough?
Personally I wouldn't expect alert message in this case.
And after clicking cancel, having 'cancel' and 'ok' button choice feels a bit awkward for me.
Contributor
There was a problem hiding this comment.
I agree with Mina, no need for Dialog here
Contributor
Author
|
Thanks for the review @minahlee @corneadoug. |
Member
|
Thanks for the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Currently, when there is no change compared with before the interpreter binding setting status, the cancel button in binding page doesn't work. So I fixed this bug.
What type of PR is it?
Bug Fix
Todos
Is there a relevant Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-508
How should this be tested?
Open the Zeppelin any notebook page -> Click the interpreter binding button
Screenshots (if appropriate)
After this PR applied,

Questions: