adding shadow to navbar if noteActionBar is not present #564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think it could be better to fix the interpreter page Action bar instead of adding another shadow |
Contributor
Author
|
I think shadow generally looks good on top bar / nav bar.
|
Contributor
|
Merging if there is no more discussions |
1 task
asfgit
pushed a commit
that referenced
this pull request
Jan 6, 2016
…sue) ### What is this PR for? The nav Dropdown menu of Zeppelin invisible. "You can not choose the create note reports, including in situations where the notebook. Cause is due to having been lowered by the z-index 2000. ### What type of PR is it? Hot Fix ### Todos * [x] - Revert code (#564) ### Is there a relevant Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-563?jql=project%20%3D%20ZEPPELIN ### How should this be tested? Outline the steps to test the PR here. click to nav dropdown menu in notebook page. ### Screenshots (if appropriate) <img width="233" alt="dropdown" src="https://cloud.githubusercontent.com/assets/10525473/12134100/bda5b476-b3e0-11e5-9121-f019e9021686.png"> ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Estail7s <estail7s@gmail.com> Closes #602 from cloverhearts/ZEPPELIN-563 and squashes the following commits: 30a1050 [Estail7s] revert add shadow nav. (invisible nav dropdown menu issue)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR adds shadow to navbar if noteActionBar is not present
What type of PR is it?
Improvement
Todos
N/A
Is there a relevant Jira issue?
N/A
Screenshots (if appropriate)
Before:
After:
