[Zeppelin 537] Improve behavior of reloading notebooks from storage #573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ae08e71. Conflicts: zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/NotebookRepoSync.java zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/repo/NotebookRepoSyncTest.java
Member
|
Tested and LGTM. |
This reverts commit b03cde2.
- Address @khalidhuseynov comment
Member
Author
|
@khalidhuseynov Keeping notebookRepo class for the flexibility makes perfect sense. I just addressed it please review |
Member
|
Looks good to me! |
Contributor
|
LGTM |
Member
|
LGTM, merge if there're no more discussions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Improve behavior of reloading notebooks from storage
What type of PR is it?
Improvement
Is there a relevant Jira issue?
ZEPPELIN-537
How should this be tested?
notebookId/note.jsonunderZEPPELIN_HOME/notebookScreenshots (if appropriate)
Questions: