ZEPPELIN-544 ] After the restart when setting bug fixes interpreters note paragraphs state.

[cloverhearts]

What is this PR for?

Restful api - call upon the setting / interpreter id type,
The problem occurs in the status of running Paragraphs.

• Paragraphs status code changes and restart missing

What type of PR is it?

Bug Fix

Todos

Is there a relevant Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-544

How should this be tested?

Paragraphs running after interpreter config change, save -> click okay on restart dialog

Screenshots (if appropriate)

before

after

Questions:

• Does the licenses files need update? no
• Is there breaking changes for older versions? no
• Does this needs documentation? no

[HeartSaVioR]

It would be better to refactor setPropertyAndRestart() and restart() to remove duplication and prevent diverged issue like this.

[cloverhearts]

@HeartSaVioR Okay, I will attempt to code refactoring.

[HeartSaVioR]

Great for finding missed spot!

[cloverhearts]

@HeartSaVioR Thank you for Feedback. have a nice day!

[HeartSaVioR]

Minor: How about extracting whole synchronized block to new private method?

Actually setPropertyAndRestart() and restart() takes same logic except setting additional parameter and calling saveToFile().

setPropertyAndRestart() can call saveToFile() safely when new method is executed without InterpreterException. So new private method doesn't need to take care about safeToFile().

Next concern is that how we can unify logic whether two parameters are presented or not.
It would be achieved easily with null check, but someone can think it's not beautiful.
So I'd like to hear our opinions about this suggestion.

[cloverhearts]

@HeartSaVioR
I agree with your opinion.
But this is a PR for a bug-fix.
I do not want to put undue changes here.
I am concerned that a new bug occurs.
Once I quit the modification here.

[HeartSaVioR]

@cloverhearts OK, Don't worry. I'll address it to another issue. :) Happy new year!

[cloverhearts]

@HeartSaVioR Happy new year, HeartSaVioR!

[HeartSaVioR]

Forgot to say LGTM. :)

[Leemoonsoo]

LGTM and merge if there're no more discussions