Skip to content

Conversation

@TYMichaelChen
Copy link
Contributor

What is this PR for?

Added a keyboard shortcut to toggle enable/disable of running a paragraph

What type of PR is it?

Improvement

Todos

Is there a relevant Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-608

How should this be tested?

Click in paragraph and press ctrl+alt+s

Screenshots (if appropriate)

after

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@Leemoonsoo
Copy link
Member

It's not been merged yet but checkpoint feature is working in progress at #577. How about keep Ctrl-Alt-s for the checkpoint? Ipython/Jupyter also uses 's' for save/checkpoint.

@TYMichaelChen
Copy link
Contributor Author

@Leemoonsoo- gotcha. that makes sense. how about ctrl+alt+r? I changed it in the newest update, but open to other shortcut keys too.

@felixcheung
Copy link
Member

+1 on ctrl-alt-r
btw, should we have these mapping for Mac (doesn't have alt key)

@Leemoonsoo
Copy link
Member

ctrl+alt+r.
Looks good to me.

on osx, option key works instead of alt key.

@TYMichaelChen
Copy link
Contributor Author

yup. on mac option works for alt. Should we have a line on the keyboard-shortcut modal to clarify that alt can be replaced by option on macs?

@Leemoonsoo
Copy link
Member

Yes, if we have a line for using option key on macs, that definitely would help

@felixcheung
Copy link
Member

is it possible show different key name in the shortcut list based on the platform the user is on? this could be a separate PR.

Merging this if there is no more discussion.

@TYMichaelChen
Copy link
Contributor Author

@felixcheung : good suggestion on the shortcut list. Thanks. I opened a separate PR for it here: #665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants