-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Added Kerberos documentation #640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for contribution @sejunra Right now CI fails on the new file you have added, as it does not have an apache licence header. Would you care for adding one please? |
|
Thanks for the documentation. |
|
@Leemoonsoo kept it on manual instead of your recommended /interpreter folder as it made more sense under /manual which is more how-tos and not related to interpreters (though it's specific to spark). If you feel strongly about the /interpreter location, I can move it. |
|
@sejunra Then the duplication that this documents made (instruction for SPARK_HOME and HADOOP_CONF_DIR) also can be removed. And user can see all necessary information in a single place. It's up to you, but i suggest move it into docs/interpreter/spark.md or at least update doc to make it clear that the instruction is for only Spark interpreter. |
|
@sejunra any update? |
|
sorry. thought i already pushed. done. |
docs/interpreter/spark.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be ../assets/themes/zeppelin/img/docs-img/...
|
Made all changes as requested. |
|
looks good to me - @AhyoungRyu @Leemoonsoo ? |
|
LGTM |
docs/interpreter/spark.md
Outdated
|
|
||
| <br /> | ||
| ### Setting up Zeppelin with Kerberos | ||
| <hr /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sejunra After applying this PR, I noticed there is already horizon line below the title because of Zeppelin's style.css.
So, you don't need to add additional <hr> tag : )
|
I left some comments in this file. Except them, LGTM! : ) |
|
@AhyoungRyu thank you for a thoughtful review! |
|
@bzz I've addressed and pushed them : ) |
docs/interpreter/spark.md
Outdated
| 2. Set SPARK\_HOME in [ZEPPELIN\_HOME]/conf/zeppelin-env.sh to use spark-submit | ||
| ( Additionally, you might have to set “export HADOOP\_CONF\_DIR=/etc/hadoop/conf” ) | ||
|
|
||
| 3. Add the two properties below to spark configuration ([SPARK_HOME]/conf/spark-defaults.conf): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't we need to escape _ in SPARK_HOME here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@felixcheung I don't know the exact reason, but that SPARK_HOME is shown properly.

|
Thank you so much for taking care! Merging this guy if there is no more discussion. |
|
Let's merge! : ) |

What is this PR for?
Added Kerberos setup with Zeppelin
What type of PR is it?
Documentation
Is there a relevant Jira issue?
No
How should this be tested?
Check out the website
Screenshots (if appropriate)
Questions: