Skip to content

Conversation

@sejunra
Copy link
Contributor

@sejunra sejunra commented Jan 15, 2016

What is this PR for?

Added Kerberos setup with Zeppelin

What type of PR is it?

Documentation

Is there a relevant Jira issue?

No

How should this be tested?

Check out the website

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@bzz
Copy link
Member

bzz commented Jan 15, 2016

Thank you for contribution @sejunra

Right now CI fails on the new file you have added, as it does not have an apache licence header.

 Unknown Licenses

*******************************

Unapproved licenses:

  docs/manual/conf_kerberos.md

*******************************

Would you care for adding one please?
See this example for a licence header in docs, right before {% include JB/setup %}

@Leemoonsoo
Copy link
Member

Thanks for the documentation.
While the documentation is specific for Spark Interpreter, why not adding it under /docs/interpreter/spark.md ?

@sejunra
Copy link
Contributor Author

sejunra commented Jan 16, 2016

@Leemoonsoo kept it on manual instead of your recommended /interpreter folder as it made more sense under /manual which is more how-tos and not related to interpreters (though it's specific to spark). If you feel strongly about the /interpreter location, I can move it.

@Leemoonsoo
Copy link
Member

@sejunra
The docs/interpreter/spark.md supposed to have configurations for Spark Interpreter. And this document have instruction for configuring SparkInterpreter with Kerberos enabled yarn cluster. Not applied to any other interpreter nor Zeppelin server daemon. I think docs/interpreter/spark.md natural place to be.

Then the duplication that this documents made (instruction for SPARK_HOME and HADOOP_CONF_DIR) also can be removed. And user can see all necessary information in a single place.

It's up to you, but i suggest move it into docs/interpreter/spark.md or at least update doc to make it clear that the instruction is for only Spark interpreter.

@felixcheung
Copy link
Member

@sejunra any update?

@sejunra
Copy link
Contributor Author

sejunra commented Feb 2, 2016

sorry. thought i already pushed. done.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be ../assets/themes/zeppelin/img/docs-img/...

@sejunra
Copy link
Contributor Author

sejunra commented Feb 5, 2016

Made all changes as requested.

@felixcheung
Copy link
Member

looks good to me - @AhyoungRyu @Leemoonsoo ?

@Leemoonsoo
Copy link
Member

LGTM


<br />
### Setting up Zeppelin with Kerberos
<hr />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sejunra After applying this PR, I noticed there is already horizon line below the title because of Zeppelin's style.css.

screen shot 2016-02-08 at 6 27 32 pm

So, you don't need to add additional <hr> tag : )

@AhyoungRyu
Copy link
Contributor

I left some comments in this file. Except them, LGTM! : )

@bzz
Copy link
Member

bzz commented Feb 14, 2016

@AhyoungRyu thank you for a thoughtful review!
If you have a spare moment and could contribute those 2 changes, please do, as it might really speed merging this on a lot.

@AhyoungRyu
Copy link
Contributor

@bzz I've addressed and pushed them : )

2. Set SPARK\_HOME in [ZEPPELIN\_HOME]/conf/zeppelin-env.sh to use spark-submit
( Additionally, you might have to set “export HADOOP\_CONF\_DIR=/etc/hadoop/conf” )

3. Add the two properties below to spark configuration ([SPARK_HOME]/conf/spark-defaults.conf):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we need to escape _ in SPARK_HOME here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felixcheung I don't know the exact reason, but that SPARK_HOME is shown properly.
screen shot 2016-02-15 at 1 02 53 pm

@bzz
Copy link
Member

bzz commented Feb 15, 2016

Thank you so much for taking care!

Merging this guy if there is no more discussion.

@AhyoungRyu
Copy link
Contributor

Let's merge! : )

@asfgit asfgit closed this in 48c3c47 Feb 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants