[Zeppelin-628 ] Fix parse propertyKey in interpreter name for Hive #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I applied the commit vgmartinez@05fa23f to my repo and it works well. |
Member
|
@vgmartinez could this be brought up to date with #667 ? |
vgmartinez
force-pushed
the
bug_628_for_hive
branch
from
bab0b0c to
5953458
Compare
Contributor
Author
|
hi @felixcheung @jongyoul.... |
Member
|
looks good. what is the plan to refactor this code into a single codebase? |
Member
|
@felixcheung I hope this would be merged into JDBC until releasing 0.6.0-incuating. I'll make a discussion mail thread on dev@ |
Member
|
merging if no more comment |
prabhjyotsingh
pushed a commit
to prabhjyotsingh/zeppelin
that referenced
this pull request
Feb 19, 2016
### What is this PR for? Fix bug https://issues.apache.org/jira/browse/ZEPPELIN-628 ### Todos ### How should this be tested? run a query that contains (something)...eg: ``` %hive select max(ss_promo_sk), ss_customer_sk from qhive.tpcds_orc_500.store_sales where ss_sold_date_sk >= 2452640 and ss_customer_sk > 3 and ss_customer_sk < 20 group by ss_customer_sk ``` It is ok if the **propertyKey** is default: ``` PropertyKey: default, SQL command: 'select max(ss_promo_sk), ss_customer_sk from qhive.tpcds_orc_500.store_sales where ss_sold_date_sk >= 2452640 and ss_customer_sk > 3 and ss_customer_sk < 20 group by ss_customer_sk' ``` ### Questions: Does the licenses files need update? no Is there breaking changes for older versions? no Does this needs documentation? no Author: vgmartinez <viktor.manuel.garcia@gmail.com> Closes apache#668 from vgmartinez/bug_628_for_hive and squashes the following commits: 5953458 [vgmartinez] add control of default in interpret 10bd7e5 [vgmartinez] fix parse propertyKey and add test 85161f9 [vgmartinez] add test for parse propertyKey 470c2ac [vgmartinez] fix parse propertykey in name interpreter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Fix bug
https://issues.apache.org/jira/browse/ZEPPELIN-628
Todos
How should this be tested?
run a query that contains (something)...eg:
It is ok if the propertyKey is default:
Questions:
Does the licenses files need update? no
Is there breaking changes for older versions? no
Does this needs documentation? no