Add new selenium test case for create new paragraph button #688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| createNewNote(); | ||
|
|
||
| waitForParagraph(1, "READY"); | ||
| Integer nosOfParas = driver.findElements(By.xpath("//div[@ng-controller=\"ParagraphCtrl\"]")).size(); |
Contributor
There was a problem hiding this comment.
extra space after "="
…ad of <true> or <false>
Member
|
Could this test also cover new paragraph by clicking + button between paragraphs? |
Contributor
Author
|
@Leemoonsoo This test does not cover new paragraph by clicking + buttons between paragraphs |
Contributor
Author
|
@Leemoonsoo Modified test case to cover new paragraph by clicking + buttons between paragraph. |
Member
|
@ravicodder Thanks for taking care. LGTM |
Member
|
Merge if there're no more discussions |
Contributor
|
@ravicodder I think you should test both append paragraph to top, and append paragraph to bottom buttons as well. Instead of only testing append to top. |
Contributor
Author
|
@prabhjyotsingh Modified test case to include test case to test append paragraph to top and bottom. |
Contributor
|
CI green, LGTM. |
Member
|
LGTM and merge if there're no more discussion |
rranjan03
force-pushed
the
testCreateNewButton
branch
from
6c3d192 to
ce25396
Compare
prabhjyotsingh
pushed a commit
to prabhjyotsingh/zeppelin
that referenced
this pull request
Feb 19, 2016
### What is this PR for? Add a new test case for testing the create new button. Create new button is for creating new paragraph within notebook ### What type of PR is it? Test ### Is there a relevant Jira issue? NA ### How should this be tested? On OSX, you'll need firefox 42.0 installed, then you can run with PATH=~/Applications/Firefox.app/Contents/MacOS/:$PATH CI="" \ mvn -Dtest=org.apache.zeppelin.ParagraphActionsIT -Denforcer.skip=true \ test -pl zeppelin-server ### Questions: * Does the licenses files need update?NO * Is there breaking changes for older versions?NO * Does this needs documentation?NO Author: Ravi Ranjan <ranjanravi0308@gmail.com> Closes apache#688 from ravicodder/testCreateNewButton and squashes the following commits: 7d5bc65 [Ravi Ranjan] Add LOG.error message in catch statement ce25396 [Ravi Ranjan] Add LOG.error in catch statement 0247d3f [Ravi Ranjan] Modified test case to test create new paragraph using '+' sign between paragraph 2fbf220 [Ravi Ranjan] modified Debug message and in checkthat value of pargarphs used instead of <true> or <false> 9b1d777 [Ravi Ranjan] Add new selenium test case for create new paragraph button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Add a new test case for testing the create new button.
Create new button is for creating new paragraph within notebook
What type of PR is it?
Test
Is there a relevant Jira issue?
NA
How should this be tested?
On OSX, you'll need firefox 42.0 installed, then you can run with
PATH=~/Applications/Firefox.app/Contents/MacOS/:$PATH CI=""
mvn -Dtest=org.apache.zeppelin.ParagraphActionsIT -Denforcer.skip=true
test -pl zeppelin-server
Questions: