ZEPPELIN-657: Change the official location of Zeppelin in the documentation #700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/development/howtocontribute.md
Outdated
| ### Getting the source code | ||
| First of all, you need the Zeppelin source code. The official location for Zeppelin is [https://github.com/apache/incubator-zeppelin](https://github.com/apache/incubator-zeppelin) | ||
| ## Getting the source code | ||
| First of all, you need Zeppelin source code. The official location of Zeppelin is [http://git.apache.org/incubator.git](http://git.apache.org/incubator-zeppelin.git). |
Member
There was a problem hiding this comment.
[http://git.apache.org/incubator.git](http://git.apache.org/incubator-zeppelin.git)
I think this should be
[http://git.apache.org/incubator-zeppelin.git](http://git.apache.org/incubator-zeppelin.git)
Member
|
shouldn't it be git: instead of http:? |
| echo '# git clone the incubator-zeppelin branch into this directory' | ||
| echo | ||
| echo 'git clone https://github.com/apache/incubator-zeppelin.git' | ||
| echo 'git clone http://git.apache.org/incubator.git' |
Contributor
Author
|
@felixcheung yeah, you're right. I changed all of the locations and also applied it to |
CONTRIBUTING.md
Outdated
| ``` | ||
|
|
||
| You may also want to develop against a specific release. For example, for branch-0.1 | ||
| You may also want to develop against a specific release. For example, for branch-0.5.6 |
Member
There was a problem hiding this comment.
Precisely, releases are available through tag in v[X].[Y].[Z] format. Let's change sentence from ... against a specific release. ... to ... against a specific branch.
Contributor
Author
|
@Leemoonsoo I changed them in two files and pushed again : ) |
Member
|
Thanks. LGTM |
Member
|
LGTM |
Member
|
Thanks @AhyoungRyu I'm merging it. |
prabhjyotsingh
pushed a commit
to prabhjyotsingh/zeppelin
that referenced
this pull request
Feb 11, 2016
…tation ### What is this PR for? Lately, an official location of Zeppelin was changed from **https://github.com/apache/incubator-zeppelin.git** to **http://git.apache.org/incubator-zeppelin.git**. So I changed the old location in several documentations to the latest one. ### What type of PR is it? Documentation ### Todos ### Is there a relevant Jira issue? [ZEPPELIN-657](https://issues.apache.org/jira/browse/ZEPPELIN-657) ### How should this be tested? ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Ryu Ah young <fbdkdud93@hanmail.net> Closes apache#700 from AhyoungRyu/ZEPPELIN-657 and squashes the following commits: 2144bcc [Ryu Ah young] ZEPPELIN-657: Change 'release' -> 'branch' in howtocontribute.md 813b438 [Ryu Ah young] ZEPPELIN-657: Change 'release' -> 'branch' 23646e5 [Ryu Ah young] ZEPPELIN-657: Fix the wrong locations c4bef6c [Ryu Ah young] ZEPPELIN-657: fix a typo in howtocontribute.md a5fb130 [Ryu Ah young] ZEPPELIN-657: Change the official location of Zeppelin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Lately, an official location of Zeppelin was changed from https://github.com/apache/incubator-zeppelin.git to http://git.apache.org/incubator-zeppelin.git. So I changed the old location in several documentations to the latest one.
What type of PR is it?
Documentation
Todos
Is there a relevant Jira issue?
ZEPPELIN-657
How should this be tested?
Screenshots (if appropriate)
Questions: