Add link to code of conduct / how it works, from CONTRIBUTING.md #707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leemoonsoo
changed the title
Member
|
LGTM |
CONTRIBUTING.md
Outdated
|
|
||
| Before you start, please read the [Code of Conduct](http://www.apache.org/foundation/policies/conduct.html) carefully, familiarise yourself with it and refer to it whenever you need it. | ||
|
|
||
| For those of who are not familiar with Apache project, understanding how [How it works](http://www.apache.org/foundation/how-it-works.html) would be quite helpful. |
Contributor
There was a problem hiding this comment.
@Leemoonsoo How about deleting "how" ?( i mean the former one )
Except this, LGTM!
Contributor
There was a problem hiding this comment.
For those of who are not -> For those of you who are not
And like it was said, there is a double how in that sentence
Member
Author
|
@jongyoul @AhyoungRyu @corneadoug Thanks for the review. I have addressed the comment. |
Member
Author
|
CI failing is irrelevant. Merge if there're no more discussions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Adding code of conduct link http://www.apache.org/foundation/policies/conduct.html to our contribution guide, as well as http://www.apache.org/foundation/how-it-works.html
What type of PR is it?
Improvement
Todos
Is there a relevant Jira issue?
no
How should this be tested?
N/A
Screenshots (if appropriate)
N/A
Questions: