Fix broken form of keyboard shortcut modal page #715
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM |
1 similar comment
Member
|
LGTM |
Contributor
|
Looks Good! |
Contributor
|
+1 |
| <div class="col-md-4"> | ||
| <div class="keys"> | ||
| <kbd class="kbd-dark">Ctrl</kbd> + <kbd class="kbd-dark">{{ isMac ? 'Option' : 'Alt'}}</kbd> + <kbd class="kbd-dark">o</kbd> | ||
| <kbd class="kbd-dark">Ctrl</kbd> + <kbd class="kbd-dark">Alt</kbd> + <kbd class="kbd-dark">r</kbd> |
Member
There was a problem hiding this comment.
it looks like this Alt should be {{ isMac ? 'Option' : 'Alt'}}? Basically everywhere we have Alt should say Option on Mac
Member
Author
There was a problem hiding this comment.
I completely missed that! Thank you for the review as always.
Member
|
LGTM!! |
Contributor
|
LGTM |
prabhjyotsingh
pushed a commit
to prabhjyotsingh/zeppelin
that referenced
this pull request
Feb 19, 2016
### What is this PR for? Fix broken form of keyboard shortcut help modal ### Is there a relevant Jira issue? No ### Screenshots (if appropriate) **Before**  **After**  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Mina Lee <minalee@nflabs.com> Closes apache#715 from minahlee/fix/keyboardShortcutHelp and squashes the following commits: eab10c1 [Mina Lee] Change Alt to be Option in Mac 1b684ca [Mina Lee] Fix broken form of keyboard shortcut modal page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Fix broken form of keyboard shortcut help modal
Is there a relevant Jira issue? No
Screenshots (if appropriate)
Before
After
Questions: