Return empty file list instead of throwing error when dependency artifact is empty #716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minahlee
force-pushed
the
fix/emptyArtifact
branch
from
55ee721 to
22d5344
Compare
2 tasks
Contributor
|
Hi @minahlee I am not in the position to build zeppelin right now. I can test it over the weekend, if this is fine for you. |
Member
Author
|
@FRosner Sure take your time and thank you for keeping your eyes on it :) |
Member
|
Changes looks good to me. |
Member
|
looks good |
Member
|
Merge if there're no more discussions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR returns empty list of dependency files instead of throwing error when dependency artifact input form in interpreter setting is empty.
What type of PR is it?
Bug Fix
Is there a relevant Jira issue?
No. The bug is reported through comment in #673
Questions: