Skip to content

Added CSV and Tableau export functionality#725

Closed
markncooper wants to merge 1 commit intoapache:masterfrom
brigade:exporterFeature
Closed

Added CSV and Tableau export functionality#725
markncooper wants to merge 1 commit intoapache:masterfrom
brigade:exporterFeature

Conversation

@markncooper
Copy link

** What is this PR for?

Allow users to export data in a paragraph to a CSV and / or Tableau via Tableau's WDC feature

** What type of PR is it?

Feature

** TODOs

This feature is partially incomplete - I want to drop the limit on only exporting 1000 (or however many) rows are shown in the UI. For our purpose we hacked backend support for this to our custom interpreter but I am looking for recommendations on the "proper" way to do this.

** Is there a relevant Jira issue?

Sort of - ZEPPELIN-672 is the most similar

**How should this be tested?

create a paragraph with data in %table view
select the "Export to CSV" or "Export to Tableau WDC" item in the paragraph settings list

** Does the licenses files need update?
NO

** Is there breaking changes for older versions?
NO

** Does this needs documentation?
Possibly. Here's a screenshot of it in action.

csvexport
tableauexport

@zhongneu
Copy link
Contributor

@markncooper I am working on a pull request for this: #714

I think we can directly export the data in frontend

@markncooper
Copy link
Author

The big issue with simply exporting from the frontend is that you can only export as many rows as are displayed by the UI, right? I'd like to dump 1000s of rows.

@zhongneu
Copy link
Contributor

@markncooper Right, but if the export button is in the chart interface, shouldn't we only export the rows shown in UI?

I also have a very similar case of exporting the "full report" than only the data UI shows. I am trying to work on some walk-around: create a dynamic form (or angular) for exporting the full reports, and register the exporting action on the dynamic form.

@jongyoul
Copy link
Member

@markncooper @zhongneu Hello folks, this issue is handled by #6 initially. I think it's better that we focus one PR only. Do you mind improving #6 by comment or some implementations? In case of same issue with many PR, I think we should respect the first one. How about you guys?

@Leemoonsoo
Copy link
Member

@markncooper Thanks for the contribution.

If you're trying to drop limit of number of rows to be downloaded, how about following approach?

Make an abstraction of any result data and share it to the ResourcePool. And then it can be used in rest end point to be downloaded. This approach was discussed in #413

@jmrr
Copy link

jmrr commented May 9, 2016

I'm a bit confused. @corneadoug said in #761 that this PR, #725, will handle the export via a REST call through the Settings button. However @jongyoul mentions that #6 will take care of this capability but @zhongneu is working on #714. At the same time #761 has been merged with a misleading title and reduction of features. I understand we haven't come up with the best approach but the issue would benefit from some consensus, as the approach of having multiple overlapping PRs on the same topic has hampered the development of the feature. I haven't started any of these PRs but I offer myself to test them and benchmark them.

@corneadoug
Copy link
Contributor

@jmrr Yes, The goal was to take care of the export using #714 and #725 (for front and back-end export).
This would allow most of the PR to be merged, and a good thing about it is that the feature is not connected directly to the table plugin we want to use. #858 for example is proposing a new table.
#761 was merged without a change in title indeed (so it can be misleading).

@jmrr
Copy link

jmrr commented Jun 1, 2016

So how are we on this?

@corneadoug
Copy link
Contributor

@jmrr Good Question.
Front-end Download has been merged, now we could also add some backend one for full data download.

@markncooper any feedbacks regarding @Leemoonsoo comments above?

@jmrr
Copy link

jmrr commented Jun 12, 2016

@corneadoug Edit my previous comment, the featured emerged when I disabled caching, the browser was caching the old view and it wouldn't appear. Sorry!

@corneadoug has front-end download really been merged? Do you mean #761 that was originally named "add download..." or something like that? Sorry but I don't see the download button :|

@sejunra
Copy link
Contributor

sejunra commented Jan 9, 2017

any update on this?

@jongyoul
Copy link
Member

It looks unmanaged now

@markncooper
Copy link
Author

Yeah, I'll abort this change as it's been implemented by others.

@brigade-gerrit brigade-gerrit deleted the exporterFeature branch November 7, 2017 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants