[HOTFIX] Add checkpoint() method implementation #726
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for catching up with latest API, looks good! |
| @Override | ||
| public void checkpoint(String noteId, String checkPointName) throws IOException { | ||
| // no-op | ||
| LOG.info("Checkpoint feature isn't suported in {}", this.getClass().toString()); |
Member
|
looks good |
Contributor
|
looks good, thanks for handling that |
Member
Author
|
Thanks guys for review. |
prabhjyotsingh
pushed a commit
to prabhjyotsingh/zeppelin
that referenced
this pull request
Feb 19, 2016
### What is this PR for? While merging apache#697, NotebookRepo API changed. And it breaks master branch. This PR implement checkpoint() method to fix it. ### What type of PR is it? Hot Fix ### Todos * [x] - Implement checkpoint() ### Is there a relevant Jira issue? ZEPPELIN-656 ### How should this be tested? build master branch ### Screenshots (if appropriate) N/A ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <moon@apache.org> Closes apache#726 from Leemoonsoo/ZEPPELIN-656_hotfix and squashes the following commits: 6dbf024 [Lee moon soo] suported -> supported 3a61696 [Lee moon soo] Add checkpoint() method implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
While merging #697, NotebookRepo API changed.
And it breaks master branch. This PR implement checkpoint() method to fix it.
What type of PR is it?
Hot Fix
Todos
Is there a relevant Jira issue?
ZEPPELIN-656
How should this be tested?
build master branch
Screenshots (if appropriate)
N/A
Questions: