replace standard alert and confirm with BootstrapDialog#802
Closed
prabhjyotsingh wants to merge 1 commit intoapache:masterfrom
Closed
replace standard alert and confirm with BootstrapDialog#802prabhjyotsingh wants to merge 1 commit intoapache:masterfrom
prabhjyotsingh wants to merge 1 commit intoapache:masterfrom
Conversation
Member
|
LGTM |
Member
|
Tested and LGTM |
Member
|
Merge into master if there're no more discussions. |
onkarshedge
pushed a commit
to onkarshedge/incubator-zeppelin
that referenced
this pull request
May 11, 2016
### What is this PR for? Replace standard alert and confirm with BootstrapDialog. Most of these were already take care by apache#501 ### What type of PR is it? Bug Fix ### What is the Jira issue? N/A ### How should this be tested? Try accessing a notebook by user who is not authorized, instead of standard alert there should be a BootstrapDialog. ### Screenshots (if appropriate) Before:  After:  Author: Prabhjyot Singh <prabhjyotsingh@gmail.com> Closes apache#802 from prabhjyotsingh/bootstrapDialog and squashes the following commits: c561688 [Prabhjyot Singh] replace standard alert and confirm with BootstrapDialog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Replace standard alert and confirm with BootstrapDialog.
Most of these were already take care by #501
What type of PR is it?
Bug Fix
What is the Jira issue?
N/A
How should this be tested?
Try accessing a notebook by user who is not authorized, instead of standard alert there should be a BootstrapDialog.
Screenshots (if appropriate)
Before:
After:
