Skip to content

[ZEPPELIN-915] New registration mechanism applied to JDBCInterpreter#954

Closed
ralphgee wants to merge 1 commit intoapache:masterfrom
ralphgee:pr915
Closed

[ZEPPELIN-915] New registration mechanism applied to JDBCInterpreter#954
ralphgee wants to merge 1 commit intoapache:masterfrom
ralphgee:pr915

Conversation

@ralphgee
Copy link
Contributor

@ralphgee ralphgee commented Jun 2, 2016

What is this PR for?

This PR applies the new interpreter registration mechanism to the JDBCInterpreter.

What type of PR is it?

Improvement

Todos

  • [x ] - Move interpreter registration properties from static block to interpreter-setting.json

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-915

How should this be tested?

  1. apply patch
  2. rm -r interpreter/jdbc
  3. rm conf/interpreter.json
  4. mvn clean package -DskipTests -pl jdbc
  5. bin/zeppelin-daemon.sh start
  6. run some paragraph with simple sql queries

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@jongyoul
Copy link
Member

jongyoul commented Jun 3, 2016

@ralphge Thanks for the contribution. I've tested and worked well. And CI failure is a temporary issue. Could you please re-trigger CI? It's OK to close and re-open this PR.

@jongyoul
Copy link
Member

jongyoul commented Jun 3, 2016

In addition to step for test, you should remove conf/interpreter.json before you start.

@ralphgee ralphgee closed this Jun 3, 2016
@ralphgee ralphgee reopened this Jun 3, 2016
@ralphgee ralphgee closed this Jun 3, 2016
@ralphgee ralphgee reopened this Jun 3, 2016
@ralphgee ralphgee closed this Jun 5, 2016
@ralphgee ralphgee reopened this Jun 5, 2016
@ralphgee
Copy link
Contributor Author

ralphgee commented Jun 5, 2016

I re-triggered the CI. The build was successful.

@bzz
Copy link
Member

bzz commented Jun 5, 2016

@ralphge thank you for stepping up and contributing this refactoring!
Looks great to me.

@jongyoul
Copy link
Member

jongyoul commented Jun 7, 2016

LGTM. Merging if there's no more discussion.

@asfgit asfgit closed this in 901102a Jun 7, 2016
@jongyoul
Copy link
Member

jongyoul commented Jun 7, 2016

@ralphge Could you please tell me your jira id? I cannot find you on jira with your github id.

https://issues.apache.org/jira/browse/ZEPPELIN-915

@ralphgee
Copy link
Contributor Author

ralphgee commented Jun 7, 2016

It is ralphg only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants