[ZEPPELIN-915] New registration mechanism applied to JDBCInterpreter#954
Closed
ralphgee wants to merge 1 commit intoapache:masterfrom
Closed
[ZEPPELIN-915] New registration mechanism applied to JDBCInterpreter#954ralphgee wants to merge 1 commit intoapache:masterfrom
ralphgee wants to merge 1 commit intoapache:masterfrom
Conversation
Member
|
@ralphge Thanks for the contribution. I've tested and worked well. And CI failure is a temporary issue. Could you please re-trigger CI? It's OK to close and re-open this PR. |
Member
|
In addition to step for test, you should remove conf/interpreter.json before you start. |
Contributor
Author
|
I re-triggered the CI. The build was successful. |
Member
|
@ralphge thank you for stepping up and contributing this refactoring! |
Member
|
LGTM. Merging if there's no more discussion. |
Member
|
@ralphge Could you please tell me your jira id? I cannot find you on jira with your github id. |
Contributor
Author
|
It is ralphg only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR applies the new interpreter registration mechanism to the JDBCInterpreter.
What type of PR is it?
Improvement
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-915
How should this be tested?
Screenshots (if appropriate)
Questions: