[ZEPPELIN-911] Apply new mechanism to FlinkInterpreter #977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What is this PR for? This PR applies the new interpreter registration mechanism to FlinkInterpreter. ### What type of PR is it? Improvement ### Todos - Move interpreter registration properties from static block to interpreter-setting.json ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-911 ### How should this be tested? 1. apply patch 2. rm -r interpreter/flink 3. rm conf/interpreter.json 4. mvn clean package -DskipTests -pl flink 5. bin/zeppelin-daemon.sh start 6. run some paragraph with simple Flink queries Questions: Does the licenses files need update? No Is there breaking changes for older versions? No Does this needs documentation? No
Member
|
I've tested it and worked well. LGTM. Merging if there's no more discussion. @rerngvit Could you please your jira id? I cannot assign you as a contributor |
Member
|
Looks great to me, @rerngvit thank you for contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR applies the new interpreter registration mechanism to FlinkInterpreter.
What type of PR is it?
Improvement
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-911
How should this be tested?
Questions:
Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No