small optimizations

apacheli · May 8, 2021 · 930ca38 · 930ca38
1 parent c749037
commit 930ca38
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/packer.ts b/lib/packer.ts
@@ -27,8 +27,8 @@ const bigint = (e: E, int: bigint) => {
   const index = add(e, 4);
   u8(e, int < 0n ? 1 : 0);
   let i = 0;
-  for (; int > 0; i++, int >>= 8n) {
-    u8(e, Number(int & 0xFFn));
+  for (; int > 0; i++, int /= 256n) {
+    u8(e, Number(int % 256n));
   }
   e.view.setUint32(index, i);
 };

diff --git a/lib/unpacker.ts b/lib/unpacker.ts
@@ -58,7 +58,7 @@ const unpack_string = (e: E, len: number) => {
 const unpack_large_big = (e: E, digits: number) => {
   const sign = u8(e);
   let int = 0n;
-  for (let i = 0, b = 1n; i < digits; i++, b <<= 8n) {
+  for (let i = 0, b = 1n; i < digits; i++, b *= 256n) {
     int += BigInt(u8(e)) * b;
   }
   int = sign ? -int : int;
@@ -68,7 +68,7 @@ const unpack_large_big = (e: E, digits: number) => {
 const unpack_small_big = (e: E, digits: number) => {
   const sign = u8(e);
   let int = 0;
-  for (let i = 0, b = 1; i < digits; i++, b <<= 8) {
+  for (let i = 0, b = 1; i < digits; i++, b *= 256) {
     int += u8(e) * b;
   }
   return sign ? -int : int;