130 unit conversion is broken #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accumulated changes from `dev` since Jan. 25.
|
I think this part of the code is not tested well. Pleas take this into account while you reviewing. |
…nto 15-regression-tests
bug fix
…nto 15-regression-tests
M-R-Schaefer
reviewed
Oct 4, 2023
M-R-Schaefer
reviewed
Oct 4, 2023
M-R-Schaefer
reviewed
Oct 4, 2023
M-R-Schaefer
reviewed
Oct 4, 2023
M-R-Schaefer
reviewed
Oct 4, 2023
M-R-Schaefer
reviewed
Oct 4, 2023
M-R-Schaefer
reviewed
Oct 4, 2023
Closed
|
Took care of all things we discussed. |
M-R-Schaefer
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #130: The unit convention problem in the
ds_stats.It also starts tackling issue #15, implements the first regression test and introduces the
pytest.markslow. Currently pytests marked as slow will not be executed in git actions.