-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per Batch Padded Dataset #281
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
e2beaf6
outline of PerBatchPaddedDataset
M-R-Schaefer 80ca14d
added multiprocessing BatchProcessor class
M-R-Schaefer 1c534c6
updated config file
M-R-Schaefer 7cc567e
updated test configs
M-R-Schaefer b6e09d6
added doc strings to datastes
M-R-Schaefer bfb1152
added warning filter for os.fork()
M-R-Schaefer 94db422
removed cahce dir from input config
M-R-Schaefer 4905419
removed cache_path from full config
M-R-Schaefer c4b7bb2
made num workers default to num cpus in system
M-R-Schaefer 24f60d7
set default n workers to num cpus
M-R-Schaefer a89e728
updated name key to processing
M-R-Schaefer 93cd227
added unit test for transpose dict of lsit
M-R-Schaefer dbae8bc
Merge branch 'dev' into uff_ds
M-R-Schaefer dcb44d6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d11dbfd
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume
PB
stand forparallel batches
. Maybe mention that once somewhere in the docstring, so that it is clear. I would also not writeMP
butmaterials project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The class name stands for PerBatchPadded . I guess I can just write it out.same for materials project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, I don't see "PB" written anywhere