Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mlflow fix #286

Merged
merged 10 commits into from
Jun 14, 2024
Merged

Mlflow fix #286

merged 10 commits into from
Jun 14, 2024

Conversation

M-R-Schaefer
Copy link
Contributor

made mlflow optional instead creating of the faulty extra.

@M-R-Schaefer M-R-Schaefer requested a review from PythonFZ June 14, 2024 12:58
pyproject.toml Outdated
zntrack = {version = "^0.7.2", optional = true}
mlflow = {version = "^2.11.3", extras = ["mlflow"]}
zntrack = {version = "^0.7.3", optional = true}
mlflow = {version = "^2.0.0", optional = true}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make it ^2 and not ^2.0.0 which will restrict it to mlflow 2.0.X

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

Copy link
Contributor

@PythonFZ PythonFZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

@M-R-Schaefer M-R-Schaefer merged commit ebc07ff into dev Jun 14, 2024
2 checks passed
@M-R-Schaefer M-R-Schaefer deleted the mlflow_fix branch June 14, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants