Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tensorflow to >=2.16 #140

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

misialq
Copy link
Contributor

@misialq misialq commented Jan 8, 2025

Closes #84.

I tested the changes by running the nn-classification workflow on a small dataset and compared the results to the previous version - all seemed fine.

@apcamargo
Copy link
Owner

Thank you so much, @misialq! I’ve been meaning to work on this issue a while, but haven’t had the chance. I really appreciate you taking the time to help with this!

Hopefully, this will make it easier to transition from TensorFlow to PyTorch or JAX. There are still a few TensorFlow functions in use, but I'll check if they can be replaced with Keras functions.

By the way, have you evaluated whether the speed is affected?

@apcamargo apcamargo merged commit d3dab78 into apcamargo:main Jan 17, 2025
@misialq
Copy link
Contributor Author

misialq commented Jan 17, 2025

Hey @apcamargo, I have not tried to evaluate how the speed would be affected but from my superficial test it did not feel like there was much of a difference. Thank you for accepting the PR!

Are you by any chance planning to release a new version in the nearest future?

@apcamargo
Copy link
Owner

apcamargo commented Jan 17, 2025

I was planning to try replacing TensorFlow with PyTorch before the next release (and also testing out this PR to reduce loading time), but if you need a release with Keras 3 soon, I can make one with the current code.

@misialq
Copy link
Contributor Author

misialq commented Jan 23, 2025

It would be super nice if we could get a version with the updated tensorflow available on bioconda - it would help us greatly as we are running into some dependency issues with the current version... Thanks a lot in advance!

@apcamargo
Copy link
Owner

Done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Keras 3
2 participants