Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections to bgc documentation #2

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

njeffery
Copy link

BFB

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • [ x] Short (1 sentence) summary of your PR:
    More updates and corrections to the zbgc documentation
  • [ x] Developer(s):
    njeffery ; eclare ; apcraig
  • Suggest PR reviewers from list in the column to the right.
    eclare/apcraig
  • [ x] Please copy the PR test results link or provide a summary of testing completed below.
    viewed as html
  • How much do the PR code changes differ from the unmodified code?
    • [x ] bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • [x ] No
  • Does this PR add any new test cases?
    • Yes
    • [ ]x No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • [x ] Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.
    -Corrects a typos
    -Improves the notation for the iron equations
    -Corrects the DIC equation.

-Corrects typos
-Improves the notation for the iron equations
-Corrects the DIC equation.

BFB
@apcraig
Copy link
Owner

apcraig commented Sep 10, 2024

Thanks Nicole! Keep them coming. I'll just keep merging them, we can review the generated documentation, and continue to revise as needed.

@apcraig apcraig merged commit 88cc351 into apcraig:bgcpr1 Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants