Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused login cmd #335

Merged
merged 5 commits into from
May 8, 2024
Merged

Conversation

ldming
Copy link
Collaborator

@ldming ldming commented May 8, 2024

@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines. label May 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 43.23%. Comparing base (2c04abc) to head (cef0fef).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/cmd/cluster/dataprotection.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
+ Coverage   42.80%   43.23%   +0.43%     
==========================================
  Files         213      199      -14     
  Lines       29109    27536    -1573     
==========================================
- Hits        12459    11906     -553     
+ Misses      15109    14199     -910     
+ Partials     1541     1431     -110     
Flag Coverage Δ
unittests 43.23% <0.00%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ldming ldming merged commit 1d0bcda into main May 8, 2024
7 checks passed
@ldming ldming deleted the support/remove-unused-login-cmd branch May 8, 2024 06:40
@ldming
Copy link
Collaborator Author

ldming commented May 8, 2024

/cherry-pick release-0.9

@github-actions github-actions bot added this to the Release 0.9.0 milestone May 8, 2024
Copy link

github-actions bot commented May 8, 2024

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kbcli/actions/runs/8997466429

github-actions bot pushed a commit that referenced this pull request May 8, 2024
(cherry picked from commit 1d0bcda)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] remove unused login and related commands
4 participants