Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update monitor-related and configconstraint api #351

Conversation

sophon-zt
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label May 12, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 73.68421% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 45.67%. Comparing base (2627e26) to head (9e92bbf).

Files Patch % Lines
pkg/cmd/cluster/config_observer.go 0.00% 2 Missing ⚠️
pkg/cmd/cluster/create.go 80.00% 1 Missing ⚠️
pkg/cmd/cluster/dataprotection.go 66.66% 1 Missing ⚠️
pkg/util/util.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
+ Coverage   45.63%   45.67%   +0.03%     
==========================================
  Files         165      165              
  Lines       23586    23542      -44     
==========================================
- Hits        10764    10752      -12     
+ Misses      11542    11516      -26     
+ Partials     1280     1274       -6     
Flag Coverage Δ
unittests 45.67% <73.68%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sophon-zt
Copy link
Contributor Author

/approve for test

@sophon-zt sophon-zt merged commit 2b592d2 into main May 14, 2024
12 checks passed
@sophon-zt sophon-zt deleted the support/improvement-kubeblocks-monitor-related-and-configconstraint-api-update-issue349 branch May 14, 2024 06:10
@sophon-zt
Copy link
Contributor Author

/cherry-pick release-0.9

@github-actions github-actions bot added this to the Release 0.9.0 milestone May 14, 2024
Copy link

🤖 says: Error cherry-picking.

Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging pkg/cmd/cluster/dataprotection.go
CONFLICT (content): Merge conflict in pkg/cmd/cluster/dataprotection.go
Auto-merging pkg/cmd/cluster/dataprotection_test.go
CONFLICT (content): Merge conflict in pkg/cmd/cluster/dataprotection_test.go
error: could not apply 2b592d2... chore: update monitor-related and configconstraint api (#351)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Copy link

🤖 says: ‼️ cherry pick action failed.
See: https://github.com/apecloud/kbcli/actions/runs/9074604673

sophon-zt added a commit that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] kubeblocks monitor-related and configconstraint api update
4 participants